Page MenuHomePhabricator

py3: catch TypeError during template operations
ClosedPublic

Authored by indygreg on Feb 11 2018, 9:35 PM.

Details

Summary

Two places in this code Python 3 changed from raising ValueError
to TypeError. So catch the addition exceptions.

IMO this code might be better off performing type sniffing. But
I'm not sure the implications of changing that.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Feb 11 2018, 9:35 PM
pulkit accepted this revision.Feb 12 2018, 2:21 AM
durin42 accepted this revision.Feb 12 2018, 9:28 PM
This revision is now accepted and ready to land.Feb 12 2018, 9:28 PM
This revision was automatically updated to reflect the committed changes.