Page MenuHomePhabricator

py3: preserve chunks as an iterable of bytes
ClosedPublic

Authored by indygreg on Feb 11 2018, 9:35 PM.

Details

Summary

patch.diffstat() returns a bytes. util.chunkbuffer() expects an
iterable of bytes. Feeding it a single bytes instance on Python 3
will iterate the characters as integers. This blows up
util.chunkbuffer.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Feb 11 2018, 9:35 PM
pulkit accepted this revision.Feb 12 2018, 2:36 AM
durin42 accepted this revision.Feb 12 2018, 9:30 PM
This revision is now accepted and ready to land.Feb 12 2018, 9:30 PM
This revision was automatically updated to reflect the committed changes.