This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2173

py3: add missing b'' literal to sshprotoext.py
ClosedPublic

Authored by indygreg on Feb 11 2018, 10:45 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG7db243288afb: py3: add missing b'' literal to sshprotoext.py
rHG2e1d3924fa5b: py3: add missing b'' literal to sshprotoext.py
Summary

Everywhere else in this file uses b''. I must have missed a line
when I wrote this code a few days ago.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Feb 11 2018, 10:45 PM
pulkit accepted this revision.Feb 12 2018, 2:47 AM
pulkit added a subscriber: pulkit.

This needs # skip-blame in commit message.

Closed by commit rHG2e1d3924fa5b: py3: add missing b'' literal to sshprotoext.py (authored by indygreg). · Explain WhyFeb 12 2018, 9:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/sshprotoext.py (2 lines)

Diff 5596

tests/sshprotoext.py

assert caps == b'proto=%s' % name assert caps == b'proto=%s' % name
# Filter hello and between requests. # Filter hello and between requests.
l = self._fin.readline() l = self._fin.readline()
assert l == b'hello\n' assert l == b'hello\n'
l = self._fin.readline() l = self._fin.readline()
assert l == b'between\n' assert l == b'between\n'
l = self._fin.readline() l = self._fin.readline()
assert l == 'pairs 81\n' assert l == b'pairs 81\n'
self._fin.read(81) self._fin.read(81)
# Send the upgrade response. # Send the upgrade response.
self._fout.write(b'upgraded %s %s\n' % (token, name)) self._fout.write(b'upgraded %s %s\n' % (token, name))
servercaps = wireproto.capabilities(self._repo, self._proto) servercaps = wireproto.capabilities(self._repo, self._proto)
rsp = b'capabilities: %s' % servercaps.data rsp = b'capabilities: %s' % servercaps.data
self._fout.write(b'%d\n' % len(rsp)) self._fout.write(b'%d\n' % len(rsp))
self._fout.write(rsp) self._fout.write(rsp)