This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2171

ui: use named attributes on FrameInfo instance
ClosedPublic

Authored by indygreg on Feb 11 2018, 10:45 PM.

Details

Reviewers
pulkit
durin42
Group Reviewers
hg-reviewers
Commits
rHGffcc3b977e43: ui: use named attributes on FrameInfo instance
Summary

This type has been a named tuple since Python 2.6. Use the
named attributes to improve code clarity.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Feb 11 2018, 10:45 PM
pulkit accepted this revision.Feb 12 2018, 2:48 AM
durin42 accepted this revision.Feb 12 2018, 9:32 PM
This revision is now accepted and ready to land.Feb 12 2018, 9:32 PM
Closed by commit rHGffcc3b977e43: ui: use named attributes on FrameInfo instance (authored by indygreg). · Explain WhyFeb 12 2018, 9:48 PM
This revision was automatically updated to reflect the committed changes.
durin42 added a comment.Feb 12 2018, 10:09 PM

This one I'm going to have to discard, along with D2172. I'll mail my version instead. Sigh.

Revision Contents
Changeset List

PathPackages
Mmercurial/ui.py (12 lines)

Diff 5594

mercurial/ui.py

stacklevel += 1 # get in develwarn stacklevel += 1 # get in develwarn
if self.tracebackflag: if self.tracebackflag:
util.debugstacktrace(msg, stacklevel, self.ferr, self.fout) util.debugstacktrace(msg, stacklevel, self.ferr, self.fout)
self.log('develwarn', '%s at:\n%s' % self.log('develwarn', '%s at:\n%s' %
(msg, ''.join(util.getstackframes(stacklevel)))) (msg, ''.join(util.getstackframes(stacklevel))))
else: else:
curframe = inspect.currentframe() curframe = inspect.currentframe()
calframe = inspect.getouterframes(curframe, 2) calframe = inspect.getouterframes(curframe, 2)
self.write_err('%s at: %s:%s (%s)\n' frameinfo = calframe[stacklevel]
% ((msg,) + calframe[stacklevel][1:4]))
self.write_err('%s at: %s:%s (%s)\n' % (
msg, frameinfo.filename, frameinfo.lineno,
frameinfo.function))
self.log('develwarn', '%s at: %s:%s (%s)\n', self.log('develwarn', '%s at: %s:%s (%s)\n',
msg, *calframe[stacklevel][1:4]) msg, frameinfo.filename, frameinfo.lineno,
curframe = calframe = None # avoid cycles frameinfo.function)
curframe = calframe = frameinfo = None # avoid cycles
def deprecwarn(self, msg, version, stacklevel=2): def deprecwarn(self, msg, version, stacklevel=2):
"""issue a deprecation warning """issue a deprecation warning
- msg: message explaining what is deprecated and how to upgrade, - msg: message explaining what is deprecated and how to upgrade,
- version: last version where the API will be supported, - version: last version where the API will be supported,
""" """
if not (self.configbool('devel', 'all-warnings') if not (self.configbool('devel', 'all-warnings')