Page MenuHomePhabricator

py3: use string for "close" value in commit extras
ClosedPublic

Authored by indygreg on Feb 11 2018, 9:35 PM.

Details

Summary

The extras dict on commits has string keys and values. Before this
commit, we passed "close" as an integer, which Python 2 gladly
coerced to a string during a %s formatting in the bowels of
changelog.py.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Feb 11 2018, 9:35 PM
pulkit accepted this revision.Feb 12 2018, 2:23 AM
pulkit added a subscriber: pulkit.

Maybe # skip-blame?

durin42 accepted this revision.Feb 12 2018, 9:28 PM
This revision is now accepted and ready to land.Feb 12 2018, 9:28 PM
This revision was automatically updated to reflect the committed changes.