This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2153

py3: open patches.queue in binary mode
ClosedPublic

Authored by indygreg on Feb 11 2018, 9:35 PM.

Details

Reviewers
pulkit
durin42
Group Reviewers
hg-reviewers
Commits
rHGbff95b002e33: py3: open patches.queue in binary mode
Summary

And switch to using the context manager form of open() while we're
here.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Feb 11 2018, 9:35 PM
pulkit accepted this revision.Feb 12 2018, 2:16 AM
durin42 accepted this revision.Feb 12 2018, 9:25 PM
This revision is now accepted and ready to land.Feb 12 2018, 9:25 PM
Closed by commit rHGbff95b002e33: py3: open patches.queue in binary mode (authored by indygreg). · Explain WhyFeb 12 2018, 9:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/mq.py (6 lines)

Diff 5578

hgext/mq.py

class AbortNoCleanup(error.Abort): class AbortNoCleanup(error.Abort):
pass pass
class queue(object): class queue(object):
def __init__(self, ui, baseui, path, patchdir=None): def __init__(self, ui, baseui, path, patchdir=None):
self.basepath = path self.basepath = path
try: try:
fh = open(os.path.join(path, 'patches.queue')) with open(os.path.join(path, 'patches.queue'), r'rb') as fh:
cur = fh.read().rstrip() cur = fh.read().rstrip()
fh.close()
if not cur: if not cur:
curpath = os.path.join(path, 'patches') curpath = os.path.join(path, 'patches')
else: else:
curpath = os.path.join(path, 'patches-' + cur) curpath = os.path.join(path, 'patches-' + cur)
except IOError: except IOError:
curpath = os.path.join(path, 'patches') curpath = os.path.join(path, 'patches')
self.path = patchdir or curpath self.path = patchdir or curpath
self.opener = vfsmod.vfs(self.path) self.opener = vfsmod.vfs(self.path)