( )⚙ D2726 debugcommands: support connecting to HTTP peers

This is an archive of the discontinued Mercurial Phabricator instance.

debugcommands: support connecting to HTTP peers
ClosedPublic

Authored by indygreg on Mar 8 2018, 12:31 AM.

Details

Summary

Now that we have the plumbing for logging socket activity, let's hook
it up to hg debugwireproto so we can collect low-level activity on
sockets.

The new code is a bit incomplete. But it is better than nothing:
hg debugwireproto is still heavily evolving.

The added test demonstrates some interesting behavior. For example,
we're calling socket.makefile() and doing I/O on that. TIL. We're also
sending an "Accept-Encoding: identity" request header.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Mar 8 2018, 12:31 AM
durin42 accepted this revision.Mar 19 2018, 9:36 PM
This revision is now accepted and ready to land.Mar 19 2018, 9:36 PM
This revision was automatically updated to reflect the committed changes.