This is an archive of the discontinued Mercurial Phabricator instance.

hgweb: construct static URL like hgweb does
ClosedPublic

Authored by indygreg on Mar 12 2018, 5:16 PM.

Details

Summary

hgwebdir has a bit of code for constructing URLs. This reinvents wheels
from our parsedrequest instance. And sometimes the behavior varies
from what hgweb does. We'll want to converge that behavior.

This commit changes hgwebdir so its staticurl template keyword
is constructed the same way as hgweb's. There's probably room
to factor this into a shared function. But let's solve the
problem of divergence first.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Mar 12 2018, 5:16 PM
durin42 accepted this revision.Mar 12 2018, 5:26 PM
This revision is now accepted and ready to land.Mar 12 2018, 5:26 PM
This revision was automatically updated to reflect the committed changes.