hgweb: perform all parameter lookup via qsparams
ClosedPublic

Authored by indygreg on Mar 10 2018, 3:57 PM.

Details

Summary

I think I managed to update all call sites using wsgirequest.form
to use parsedrequest.qsparams.

Since behavior of qsparams is to retrieve last value, behavior will
change if a parameter was specified multiple times. But I think this
is acceptable.

I'm not a fan of the req.req.qsparams pattern. And some of the
modified code could be written better. But I was aiming for a
straight port with this change. Cleanup can come later.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
indygreg created this revision.Mar 10 2018, 3:57 PM
durin42 accepted this revision.Mar 12 2018, 5:05 PM
This revision is now accepted and ready to land.Mar 12 2018, 5:05 PM
This revision was automatically updated to reflect the committed changes.