This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2816

hgweb: remove unused **map argument
ClosedPublic

Authored by indygreg on Mar 12 2018, 5:16 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHGee395147bb28: hgweb: remove unused **map argument
Summary

It was unused before the recent code refactoring AFAICT.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Mar 12 2018, 5:16 PM
durin42 accepted this revision.Mar 12 2018, 5:25 PM
This revision is now accepted and ready to land.Mar 12 2018, 5:25 PM
Closed by commit rHGee395147bb28: hgweb: remove unused **map argument (authored by indygreg). · Explain WhyMar 12 2018, 5:38 PM
This revision was automatically updated to reflect the committed changes.
yuja added a subscriber: yuja.Mar 17 2018, 11:45 AM

For the record, **map was necessary to be an old-style template
keyword function, which takes all properties passed to tmpl().

Revision Contents
Changeset List

PathPackages
Mmercurial/hgweb/hgwebdir_mod.py (6 lines)

Diff 6946

mercurial/hgweb/hgwebdir_mod.py

'type': typ, 'type': typ,
'extension': spec[2], 'extension': spec[2],
'node': nodeid, 'node': nodeid,
'url': url, 'url': url,
}) })
return archives return archives
def rawindexentries(ui, repos, wsgireq, req, subdir='', **map): def rawindexentries(ui, repos, wsgireq, req, subdir=''):
descend = ui.configbool('web', 'descend') descend = ui.configbool('web', 'descend')
collapse = ui.configbool('web', 'collapse') collapse = ui.configbool('web', 'collapse')
seenrepos = set() seenrepos = set()
seendirs = set() seendirs = set()
for name, path in repos: for name, path in repos:
if not name.startswith(subdir): if not name.startswith(subdir):
continue continue
'archives': archivelist(u, "tip", url), 'archives': archivelist(u, "tip", url),
'isdirectory': None, 'isdirectory': None,
'labels': u.configlist('web', 'labels', untrusted=True), 'labels': u.configlist('web', 'labels', untrusted=True),
} }
yield row yield row
def indexentries(ui, repos, wsgireq, req, stripecount, sortcolumn='', def indexentries(ui, repos, wsgireq, req, stripecount, sortcolumn='',
descending=False, subdir='', **map): descending=False, subdir=''):
rows = rawindexentries(ui, repos, wsgireq, req, subdir=subdir, **map) rows = rawindexentries(ui, repos, wsgireq, req, subdir=subdir)
sortdefault = None, False sortdefault = None, False
if sortcolumn and sortdefault != (sortcolumn, descending): if sortcolumn and sortdefault != (sortcolumn, descending):
sortkey = '%s_sort' % sortcolumn sortkey = '%s_sort' % sortcolumn
rows = sorted(rows, key=lambda x: x[sortkey], rows = sorted(rows, key=lambda x: x[sortkey],
reverse=descending) reverse=descending)