wireproto: require POST for all HTTPv2 requests

Authored by indygreg on Mon, Mar 12, 10:16 PM.



Wire protocol version 1 transfers argument data via request
headers by default. This has historically caused problems because
servers institute limits on the length of individual HTTP headers
as well as the total size of all request headers. Mercurial servers
can advertise the maximum length of an individual header. But
there's no guarantee any intermediate HTTP agents will accept
headers up to that length.

In the existing wire protocol, server operators typically also
key off the HTTP request method to implement authentication.
For example, GET requests translate to read-only requests and
can be allowed. But read-write commands must use POST and require
authentication. This has typically worked because the only wire
protocol commands that use POST modify the repo (e.g. the
"unbundle" command).

There is an experimental feature to enable clients to transmit
argument data via POST request bodies. This is technically a
better and more robust solution. But we can't enable it by default
because of servers assuming POST means write access.

In version 2 of the wire protocol, the permissions of a request
are encoded in the URL. And with it being a new protocol in a new
URL space, we're not constrained by backwards compatibility

This commit adopts the technically superior mechanism of using
HTTP request bodies to send argument data by requiring POST for
all commands. Strictly speaking, it may be possible to send
request bodies on GET requests. But my experience is that not all
HTTP stacks support this. POST pretty much always works. Using POST
for read-only operations does sacrifice some RESTful design
purity. But this API cares about practicality, not about being
in Roy T. Fielding's REST ivory tower.

There's a chance we may relax this restriction in the future. But
for now, I want to see how far we can get with a POST only API.

Diff Detail

rHG Mercurial
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
indygreg created this revision.Mon, Mar 12, 10:16 PM
indygreg updated this revision to Diff 7000.Tue, Mar 13, 3:11 PM
indygreg updated this revision to Diff 7015.Tue, Mar 13, 10:49 PM
indygreg updated this revision to Diff 7136.Mon, Mar 19, 7:59 PM
durin42 accepted this revision.Wed, Mar 21, 3:18 PM
This revision is now accepted and ready to land.Wed, Mar 21, 3:18 PM
indygreg updated this revision to Diff 7196.Wed, Mar 21, 6:19 PM
durin42 accepted this revision.Wed, Mar 21, 6:21 PM
This revision was automatically updated to reflect the committed changes.