This is an archive of the discontinued Mercurial Phabricator instance.

wireproto: nominally don't expose "batch" to version 2 wire transports
ClosedPublic

Authored by indygreg on Mar 14 2018, 12:01 PM.

Details

Summary

The unified frame-based protocol will (eventually) support
multiple requests per client transmission. This means that the
[very hacky] "batch" command has no purpose existing in this protocol.

This commit marks the command as applying to v1 transports only.

But because SSHv2 == SSHv1 currently, we had to hack it back in
for the SSHv2 transport. Bleh.

Tests changed because the capabilities string changed. The order of
tokens in the string is not important.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Mar 14 2018, 12:01 PM
indygreg updated this revision to Diff 7049.Mar 14 2018, 9:10 PM
indygreg updated this revision to Diff 7083.Mar 16 2018, 7:25 PM
indygreg updated this revision to Diff 7141.Mar 19 2018, 7:59 PM
durin42 accepted this revision.Mar 21 2018, 9:32 PM
This revision is now accepted and ready to land.Mar 21 2018, 9:32 PM
This revision was automatically updated to reflect the committed changes.