This is an archive of the discontinued Mercurial Phabricator instance.

wireprotoserver: remove broken optimization for non-httplib client
ClosedPublic

Authored by indygreg on Mar 8 2018, 8:06 PM.

Details

Summary

There was an experimental non-httplib client in core for several
years. It was removed a week or so ago.

We kept the optimization for this client in the server code. I'm
not sure if that was intended or not. But it doesn't matter: the
code was wrong.

Because the code was accessing a WSGI environment dict, it needed to
access the HTTP_X_HGHTTP2 key to actually read the HTTP header. So
the code deleted by this commit wasn't actually doing anything
meaningful. Doh.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Mar 8 2018, 8:06 PM
durin42 accepted this revision.Mar 9 2018, 2:24 PM
This revision is now accepted and ready to land.Mar 9 2018, 2:24 PM
This revision was automatically updated to reflect the committed changes.