( )⚙ D2787 hgweb: port most @webcommand to use modern response type

This is an archive of the discontinued Mercurial Phabricator instance.

hgweb: port most @webcommand to use modern response type
ClosedPublic

Authored by indygreg on Mar 11 2018, 12:23 AM.

Details

Summary

This only focused on porting the return value.

raw file requests are wonky because they go through a separate code
path at the dispatch layer. Now that everyone is using the same
API, we could clean this up.

It's worth noting that wsgirequest.respond() allows sending the
Content-Disposition header, but the only user of that feature was
removed as part of this change (with the setting of the header
now being performed inline).

A few @webcommand are not as straightforward as the others and
they have not been ported yet.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Mar 11 2018, 12:23 AM
durin42 accepted this revision.Mar 12 2018, 5:09 PM
This revision is now accepted and ready to land.Mar 12 2018, 5:09 PM
This revision was automatically updated to reflect the committed changes.