Page MenuHomePhabricator

cleanup: join string literals that are already on one line
ClosedPublic

Authored by martinvonz on Tue, Oct 8, 6:22 PM.

Details

Summary

Thanks to Kyle for noticing this and for providing the regular
expression to run on the codebase.

This patch has been reviewed by the test suite and they approved of
it.

  1. skip-blame: fallout from mass reformatting

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Tue, Oct 8, 6:22 PM
martinvonz updated this revision to Diff 16981.Tue, Oct 8, 6:48 PM
spectral accepted this revision.Tue, Oct 8, 6:49 PM
spectral added a subscriber: spectral.

Some slightly disappointing loss of clarity where we had originally had something like:

foo(b'abc\n'
    b'def')

and this became foo('abc\n' b'def'), which is now foo('abc\ndef'): I liked the newlines ending the string and us being able to see an actual newline in the source, but that's already been lost, and this isn't making it worse in any way.

nit: add a # skip-blame: annotation to help us in the future (maybe check history to look for how it's been annotated in the past)

martinvonz edited the summary of this revision. (Show Details)Tue, Oct 8, 6:52 PM

nit: add a # skip-blame: annotation to help us in the future (maybe check history to look for how it's been annotated in the past)

Done.

pulkit accepted this revision.Wed, Oct 9, 6:03 AM
This revision is now accepted and ready to land.Wed, Oct 9, 6:03 AM