This is an archive of the discontinued Mercurial Phabricator instance.

Status	Author	Revision
Closed	durin42	D7288 archival: suppress some incorrect pytype failures
Closed	durin42	D7287 simplemerge: disable a pytype error where it's just confused
Closed	durin42	D7286 match: suppress error about subscripting an exception
Closed	durin42	D7285 vfs: more attribute suppressions
Closed	durin42	D7284 mdiff: mark diffopts as having dynamic attributes
Closed	durin42	D7283 mail: suppress a pytype error that's just experimentally wrong
Closed	durin42	D7282 vfs: suppress some pytype errors around us using a private attribute
Closed	durin42	D7281 wireprototypes: disable pytype where it's just confused
Closed	durin42	D7280 scmposix: another suppression on IOError subscripting
Closed	durin42	D7279 pvec: add an explicit type hint to help pytype
Closed	durin42	D7278 procutil: suppress pytype warnings around windows-only attributes
Closed	durin42	D7277 dagparser: suppress some pytype errors around pycompat.bytestring
Closed	durin42	D7276 posix: add a pytype suppression
Closed	durin42	D7275 encoding: add comment-based type hints for pytype
Closed	durin42	D7274 color: suppress pytype warning on a windows-only module
Closed	durin42	D7273 compression: tell pytype to not sweat a missing `zstd` module
Closed	durin42	D7272 pytype: don't warn us about ignored-on-py3 metaclasses
Closed	durin42	D7271 linelog: be more careful about types before looking for _target attribute
Closed	durin42	D7270 linelog: suppress annoying pytype warning about an ignored metaclass
Closed	durin42	D7269 hgignore: ignore generated pytype stubs
Closed	durin42	D7268 hghave: add a check for pytype, Google's Python type checker
Closed	durin42	D7267 encoding: define local identify functions with explicit type comments
Closed	durin42	D7266 vfs: add NotImplementedError version of join
Closed	durin42	D7265 vfs: add a NotImplementedError implementation of __call__
Closed	durin42	D7264 vfs: fix erroneous bytes constants
Closed	durin42	D7263 pvec: migrate to modern integer division
Closed	durin42	D7262 templateutil: fix a missing ABCMeta assignment
Closed	durin42	D7261 pvec: fix overlooked chr() call
Closed	durin42	D7260 vfs: another bytes-str confusion on thread name
Closed	durin42	D7259 statprof: correctly always pass a str as the thread name

Diff 17658

mercurial/archival.py

	def _write_gzip_header(self):			def _write_gzip_header(self):
	self.fileobj.write(b'\037\213') # magic header			self.fileobj.write(b'\037\213') # magic header
	self.fileobj.write(b'\010') # compression method			self.fileobj.write(b'\010') # compression method
	fname = self.name			fname = self.name
	if fname and fname.endswith(b'.gz'):			if fname and fname.endswith(b'.gz'):
	fname = fname[:-3]			fname = fname[:-3]
	flags = 0			flags = 0
	if fname:			if fname:
	flags = gzip.FNAME			flags = gzip.FNAME # pytype: disable=module-attr
	self.fileobj.write(pycompat.bytechr(flags))			self.fileobj.write(pycompat.bytechr(flags))
	gzip.write32u(self.fileobj, int(self.timestamp))			gzip.write32u( # pytype: disable=module-attr
				self.fileobj, int(self.timestamp)
				)
	self.fileobj.write(b'\002')			self.fileobj.write(b'\002')
	self.fileobj.write(b'\377')			self.fileobj.write(b'\377')
	if fname:			if fname:
	self.fileobj.write(fname + b'\000')			self.fileobj.write(fname + b'\000')

	def __init__(self, dest, mtime, kind=b''):			def __init__(self, dest, mtime, kind=b''):
	self.mtime = mtime			self.mtime = mtime
	self.fileobj = None			self.fileobj = None

	def taropen(mode, name=b'', fileobj=None):			def taropen(mode, name=b'', fileobj=None):
	if kind == b'gz':			if kind == b'gz':
	mode = mode[0:1]			mode = mode[0:1]
	if not fileobj:			if not fileobj:
	fileobj = open(name, mode + b'b')			fileobj = open(name, mode + b'b')
	gzfileobj = self.GzipFileWithTime(			gzfileobj = self.GzipFileWithTime(
	name,			name,
	pycompat.sysstr(mode + b'b'),			pycompat.sysstr(mode + b'b'),
	zlib.Z_BEST_COMPRESSION,			zlib.Z_BEST_COMPRESSION,
	fileobj,			fileobj,
	timestamp=mtime,			timestamp=mtime,
	)			)
	self.fileobj = gzfileobj			self.fileobj = gzfileobj
	return tarfile.TarFile.taropen(			return tarfile.TarFile.taropen( # pytype: disable=attribute-error
	name, pycompat.sysstr(mode), gzfileobj			name, pycompat.sysstr(mode), gzfileobj
	)			)
	else:			else:
	return tarfile.open(name, pycompat.sysstr(mode + kind), fileobj)			return tarfile.open(name, pycompat.sysstr(mode + kind), fileobj)

	if isinstance(dest, bytes):			if isinstance(dest, bytes):
	self.z = taropen(b'w:', name=dest)			self.z = taropen(b'w:', name=dest)
	else:			else:
	if mtime < epoch:			if mtime < epoch:
	mtime = epoch			mtime = epoch

	self.mtime = mtime			self.mtime = mtime
	self.date_time = time.gmtime(mtime)[:6]			self.date_time = time.gmtime(mtime)[:6]

	def addfile(self, name, mode, islink, data):			def addfile(self, name, mode, islink, data):
	i = zipfile.ZipInfo(pycompat.fsdecode(name), self.date_time)			i = zipfile.ZipInfo(pycompat.fsdecode(name), self.date_time)
	i.compress_type = self.z.compression			i.compress_type = self.z.compression # pytype: disable=attribute-error
	# unzip will not honor unix file modes unless file creator is			# unzip will not honor unix file modes unless file creator is
	# set to unix (id 3).			# set to unix (id 3).
	i.create_system = 3			i.create_system = 3
	ftype = _UNX_IFREG			ftype = _UNX_IFREG
	if islink:			if islink:
	mode = 0o777			mode = 0o777
	ftype = _UNX_IFLNK			ftype = _UNX_IFLNK
	i.external_attr = (mode \| ftype) << 16			i.external_attr = (mode \| ftype) << 16

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	17658		Nov 6 2019, 5:58 PM	★	★
Diff 2	17702	rHGd5bef33ab83c19e7a4c22a318123194df53f6ab3	Nov 6 2019, 4:26 PM	★	★

This is an archive of the discontinued Mercurial Phabricator instance.

archival: suppress some incorrect pytype failuresClosedPublic

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 17658

mercurial/archival.py

archival: suppress some incorrect pytype failures
ClosedPublic

Revision Contents
Changeset List