( )⚙ D7288 archival: suppress some incorrect pytype failures

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7288

archival: suppress some incorrect pytype failures
ClosedPublic

Authored by durin42 on Nov 6 2019, 5:59 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHGd5bef33ab83c: archival: suppress some incorrect pytype failures
Summary

Again, I suspect some missing coverage in type stubs for the
stdlib. I'll revisit these later.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Nov 6 2019, 5:59 PM
indygreg accepted this revision.Nov 7 2019, 3:21 AM
This revision is now accepted and ready to land.Nov 7 2019, 3:21 AM
durin42 added a commit: rHGd5bef33ab83c: archival: suppress some incorrect pytype failures.Nov 7 2019, 3:34 AM
Closed by commit rHGd5bef33ab83c: archival: suppress some incorrect pytype failures (authored by durin42). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/archival.py (10 lines)

Diff 17702

mercurial/archival.py

def _write_gzip_header(self): def _write_gzip_header(self):
self.fileobj.write(b'\037\213') # magic header self.fileobj.write(b'\037\213') # magic header
self.fileobj.write(b'\010') # compression method self.fileobj.write(b'\010') # compression method
fname = self.name fname = self.name
if fname and fname.endswith(b'.gz'): if fname and fname.endswith(b'.gz'):
fname = fname[:-3] fname = fname[:-3]
flags = 0 flags = 0
if fname: if fname:
flags = gzip.FNAME flags = gzip.FNAME # pytype: disable=module-attr
self.fileobj.write(pycompat.bytechr(flags)) self.fileobj.write(pycompat.bytechr(flags))
gzip.write32u(self.fileobj, int(self.timestamp)) gzip.write32u( # pytype: disable=module-attr
self.fileobj, int(self.timestamp)
)
self.fileobj.write(b'\002') self.fileobj.write(b'\002')
self.fileobj.write(b'\377') self.fileobj.write(b'\377')
if fname: if fname:
self.fileobj.write(fname + b'\000') self.fileobj.write(fname + b'\000')
def __init__(self, dest, mtime, kind=b''): def __init__(self, dest, mtime, kind=b''):
self.mtime = mtime self.mtime = mtime
self.fileobj = None self.fileobj = None
def taropen(mode, name=b'', fileobj=None): def taropen(mode, name=b'', fileobj=None):
if kind == b'gz': if kind == b'gz':
mode = mode[0:1] mode = mode[0:1]
if not fileobj: if not fileobj:
fileobj = open(name, mode + b'b') fileobj = open(name, mode + b'b')
gzfileobj = self.GzipFileWithTime( gzfileobj = self.GzipFileWithTime(
name, name,
pycompat.sysstr(mode + b'b'), pycompat.sysstr(mode + b'b'),
zlib.Z_BEST_COMPRESSION, zlib.Z_BEST_COMPRESSION,
fileobj, fileobj,
timestamp=mtime, timestamp=mtime,
) )
self.fileobj = gzfileobj self.fileobj = gzfileobj
return tarfile.TarFile.taropen( return tarfile.TarFile.taropen( # pytype: disable=attribute-error
name, pycompat.sysstr(mode), gzfileobj name, pycompat.sysstr(mode), gzfileobj
) )
else: else:
return tarfile.open(name, pycompat.sysstr(mode + kind), fileobj) return tarfile.open(name, pycompat.sysstr(mode + kind), fileobj)
if isinstance(dest, bytes): if isinstance(dest, bytes):
self.z = taropen(b'w:', name=dest) self.z = taropen(b'w:', name=dest)
else: else:
if mtime < epoch: if mtime < epoch:
mtime = epoch mtime = epoch
self.mtime = mtime self.mtime = mtime
self.date_time = time.gmtime(mtime)[:6] self.date_time = time.gmtime(mtime)[:6]
def addfile(self, name, mode, islink, data): def addfile(self, name, mode, islink, data):
i = zipfile.ZipInfo(pycompat.fsdecode(name), self.date_time) i = zipfile.ZipInfo(pycompat.fsdecode(name), self.date_time)
i.compress_type = self.z.compression i.compress_type = self.z.compression # pytype: disable=attribute-error
# unzip will not honor unix file modes unless file creator is # unzip will not honor unix file modes unless file creator is
# set to unix (id 3). # set to unix (id 3).
i.create_system = 3 i.create_system = 3
ftype = _UNX_IFREG ftype = _UNX_IFREG
if islink: if islink:
mode = 0o777 mode = 0o777
ftype = _UNX_IFLNK ftype = _UNX_IFLNK
i.external_attr = (mode | ftype) << 16 i.external_attr = (mode | ftype) << 16