This is an archive of the discontinued Mercurial Phabricator instance.

config: track "source" along side value
ClosedPublic

Authored by marmoute on Jan 29 2021, 8:39 PM.

Details

Summary

Currently the source is stored in a entirely different way than the data. This
is impractical. Especially if we are about to add more of such metadata. So lets
put them back together.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Jan 29 2021, 8:39 PM
Alphare accepted this revision.Feb 8 2021, 5:15 AM
Alphare added a subscriber: Alphare.

This is more in line with the (soon to be used) Rust implementation, also.

baymax updated this revision to Diff 25517.Feb 9 2021, 6:29 PM

โœ… refresh by Heptapod after a successful CI run (๐Ÿ™ ๐Ÿ’š)

baymax updated this revision to Diff 25574.Feb 11 2021, 1:46 PM

โœ… refresh by Heptapod after a successful CI run (๐Ÿ™ ๐Ÿ’š)

pulkit accepted this revision.Mar 4 2021, 6:26 AM
This revision is now accepted and ready to land.Mar 4 2021, 6:26 AM
This revision was automatically updated to reflect the committed changes.

This patch makes test-releasenotes-formatting.t fail for me. I noticed that it has #require fuzzywuzzy at the top. Could you install that (I don't even remember what it is) and send a fix?

This patch makes test-releasenotes-formatting.t fail for me. I noticed that it has #require fuzzywuzzy at the top. Could you install that (I don't even remember what it is) and send a fix?

Here is the fix: https://phab.mercurial-scm.org/D10121

and here is the MR to install fuzzywuzzy in the CI image: https://foss.heptapod.net/octobus/ci-dockerfiles/-/merge_requests/54

marmoute added a comment.EditedMar 11 2021, 12:02 PM

After discussion on IRC, the link is actually wrong, one should like at the previous function that use _source. The source information is not stored along side the value (in a (value, source, level) tuple). You can access it using `config.source(section, key).