( )⚙ D10340 sidedata: register copies sidedata computer regardless of the revlog version

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10340

sidedata: register copies sidedata computer regardless of the revlog version
ClosedPublic

Authored by Alphare on Apr 9 2021, 4:49 AM.

Details

Reviewers
marmoute
Group Reviewers
hg-reviewers
Commits
rHGb409cdc6a139: sidedata: register copies sidedata computer regardless of the revlog version
Summary

Repositories should not gate their sidedata computers based on any requirement,
only their wanted sidedata. A repository might need to generate sidedata wanted
by the peer that it itself does not want.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Alphare created this revision.Apr 9 2021, 4:49 AM
marmoute accepted this revision.Apr 9 2021, 5:59 AM
marmoute added a subscriber: marmoute.

(maybe explain why in your description, the behavior is already "encoded" in the patch)

Alphare edited the summary of this revision. (Show Details)Apr 10 2021, 3:14 PM
Alphare planned changes to this revision.Apr 20 2021, 7:51 AM

I will rebase this entire series on the one starting at D10353, that way the patches are already nice and clean and we don't risk a functional conflict when those patches land.

marmoute accepted this revision.Apr 22 2021, 1:38 PM
baymax updated this revision to Diff 27297.May 3 2021, 6:06 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 27447.May 3 2021, 9:01 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Alphare added a commit: rHGb409cdc6a139: sidedata: register copies sidedata computer regardless of the revlog version.May 5 2021, 6:38 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGb409cdc6a139: sidedata: register copies sidedata computer regardless of the revlog version (authored by Alphare). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/metadata.py (12 lines)

Diff 27447

mercurial/metadata.py

def copies_sidedata_computer(repo, revlog, rev, existing_sidedata): def copies_sidedata_computer(repo, revlog, rev, existing_sidedata):
return _getsidedata(repo, rev)[0] return _getsidedata(repo, rev)[0]
def set_sidedata_spec_for_repo(repo): def set_sidedata_spec_for_repo(repo):
if requirementsmod.COPIESSDC_REQUIREMENT in repo.requirements: if requirementsmod.COPIESSDC_REQUIREMENT in repo.requirements:
repo.register_wanted_sidedata(sidedatamod.SD_FILES) repo.register_wanted_sidedata(sidedatamod.SD_FILES)
repo.register_sidedata_computer( repo.register_sidedata_computer(
revlogconst.KIND_CHANGELOG, revlogconst.KIND_CHANGELOG,
sidedatamod.SD_FILES, sidedatamod.SD_FILES,
(sidedatamod.SD_FILES,), (sidedatamod.SD_FILES,),
copies_sidedata_computer, copies_sidedata_computer,
) )
def getsidedataadder(srcrepo, destrepo): def getsidedataadder(srcrepo, destrepo):
use_w = srcrepo.ui.configbool(b'experimental', b'worker.repository-upgrade') use_w = srcrepo.ui.configbool(b'experimental', b'worker.repository-upgrade')
if pycompat.iswindows or not use_w: if pycompat.iswindows or not use_w:
return _get_simple_sidedata_adder(srcrepo, destrepo) return _get_simple_sidedata_adder(srcrepo, destrepo)
else: else:
return _get_worker_sidedata_adder(srcrepo, destrepo) return _get_worker_sidedata_adder(srcrepo, destrepo)