This is an archive of the discontinued Mercurial Phabricator instance.

lfs: use the new APIs
ClosedPublic

Authored by marmoute on Apr 14 2021, 7:38 PM.

Details

Summary

The part of the lfs store that requires a destination cannot operate on multiple destination (yet). So we move them to the dedicated APIs.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Apr 14 2021, 7:38 PM
mharbison72 added inline comments.
hgext/largefiles/storefactory.py
43–44

Probably should update the comment too, now that the named function is gone.

marmoute added inline comments.Apr 15 2021, 3:28 AM
hgext/largefiles/storefactory.py
43–44

I was a bit confused about the comment initially, but I now understand is probably about the fact ui.expandpath(b'default') would return b'default' if no default path is defined. However the comment does not match the code I replaced.

Since I already document the "issue" in urlutil (later in the series) I'll mostly drop this comment.

marmoute updated this revision to Diff 26916.Apr 15 2021, 3:37 AM
pulkit accepted this revision.Apr 15 2021, 11:12 AM
This revision is now accepted and ready to land.Apr 15 2021, 11:12 AM
This revision was automatically updated to reflect the committed changes.