This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10438

urlutil: inline the relevant part of `getpath` in `get_push_paths`
ClosedPublic

Authored by marmoute on Apr 15 2021, 4:52 AM.

Details

Reviewers
Alphare
pulkit
Group Reviewers
hg-reviewers
Commits
rHGd69a9628eba7: urlutil: inline the relevant part of `getpath` in `get_push_paths`
rHGfb7bee1ebc03: urlutil: inline the relevant part of `getpath` in `get_push_paths`
Summary

The part that get_push_paths needs is quite simple, inclining will help us
to deprecated getpath.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Apr 15 2021, 4:52 AM
marmoute updated this revision to Diff 26947.Apr 15 2021, 10:39 AM
baymax updated this revision to Diff 27007.Apr 17 2021, 7:39 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Alphare accepted this revision.Apr 20 2021, 10:45 AM
This revision is now accepted and ready to land.Apr 20 2021, 10:45 AM
baymax updated this revision to Diff 27217.Apr 29 2021, 1:56 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

pulkit accepted this revision.Apr 30 2021, 5:54 AM
baymax updated this revision to Diff 27226.Apr 30 2021, 7:58 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Revision Contents
Changeset List

PathPackages
Mmercurial/utils/urlutil.py (10 lines)

Diff 27226

mercurial/utils/urlutil.py

yield ui.paths[b'default'] yield ui.paths[b'default']
else: else:
raise error.ConfigError( raise error.ConfigError(
_(b'default repository not configured!'), _(b'default repository not configured!'),
hint=_(b"see 'hg help config.paths'"), hint=_(b"see 'hg help config.paths'"),
) )
else: else:
for dest in dests: for dest in dests:
yield ui.getpath(dest) if dest in ui.paths:
yield ui.paths[dest]
else:
path = try_path(ui, dest)
if path is None:
msg = _(b'repository %s does not exist')
msg %= dest
raise error.RepoError(msg)
yield path
def get_pull_paths(repo, ui, sources, default_branches=()): def get_pull_paths(repo, ui, sources, default_branches=()):
"""yields all the `(path, branch)` selected as pull source by `sources`""" """yields all the `(path, branch)` selected as pull source by `sources`"""
if not sources: if not sources:
sources = [b'default'] sources = [b'default']
for source in sources: for source in sources:
if source in ui.paths: if source in ui.paths: