This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10441

paths: use `list_paths` in `hg paths`
ClosedPublic

Authored by marmoute on Apr 15 2021, 8:03 PM.

Details

Reviewers
Alphare
pulkit
Group Reviewers
hg-reviewers
Commits
rHG820fe29d0fd8: paths: use `list_paths` in `hg paths`
rHG9bfe3818d7c5: paths: use `list_paths` in `hg paths`
Summary

Using common code will make it simpler to update the logic behind the path
definition and storage.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Apr 15 2021, 8:03 PM
baymax updated this revision to Diff 27010.Apr 17 2021, 7:44 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Alphare accepted this revision.Apr 20 2021, 10:54 AM
This revision is now accepted and ready to land.Apr 20 2021, 10:54 AM
baymax updated this revision to Diff 27201.Apr 29 2021, 1:47 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

pulkit accepted this revision.Apr 30 2021, 5:56 AM
baymax updated this revision to Diff 27229.Apr 30 2021, 8:25 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

marmoute added a commit: rHG9bfe3818d7c5: paths: use `list_paths` in `hg paths`.Apr 30 2021, 10:08 AM
Closed by commit rHG9bfe3818d7c5: paths: use `list_paths` in `hg paths` (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/commands.py (10 lines)

Diff 27010

mercurial/commands.py

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
:name: String. Symbolic name of the path alias. :name: String. Symbolic name of the path alias.
:pushurl: String. URL for push operations. :pushurl: String. URL for push operations.
:url: String. URL or directory path for the other operations. :url: String. URL or directory path for the other operations.
Returns 0 on success. Returns 0 on success.
""" """
opts = pycompat.byteskwargs(opts) opts = pycompat.byteskwargs(opts)
pathitems = urlutil.list_paths(ui, search)
ui.pager(b'paths') ui.pager(b'paths')
if search:
pathitems = [
(name, path)
for name, path in pycompat.iteritems(ui.paths)
if name == search
]
else:
pathitems = sorted(pycompat.iteritems(ui.paths))
fm = ui.formatter(b'paths', opts) fm = ui.formatter(b'paths', opts)
if fm.isplain(): if fm.isplain():
hidepassword = urlutil.hidepassword hidepassword = urlutil.hidepassword
else: else:
hidepassword = bytes hidepassword = bytes
if ui.quiet: if ui.quiet:
namefmt = b'%s\n' namefmt = b'%s\n'