urlutil: add a `copy` method to `path
ClosedPublic

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	26954		Apr 15 2021, 8:03 PM	★	★
Diff 2	27014		Apr 17 2021, 7:44 PM	★	★
Diff 3	27205		Apr 29 2021, 1:47 PM	★	★
Diff 4	27233		Apr 30 2021, 8:25 AM	★	★
Diff 5	27417		May 3 2021, 9:52 AM	★	★
Diff 6	27922	rHGa2632ce1f15bb8b9fb184c9bcdf259bc258e3bd6	Apr 15 2021, 11:12 AM	★	★

Commit	Parents	Author	Summary	Date
01896a13ba21	b5abb4c44966	Pierre-Yves David		Apr 15 2021, 11:12 AM

Status	Author	Revision
Closed	marmoute	D10455 urlutil: provide some information about "bad url" when processing `pushurl`
Closed	marmoute	D10454 revset: document the `outgoing` behavior if the path resolve to multiple urls
Closed	marmoute	D10453 multi-urls: document the feature
Closed	marmoute	D10452 multi-urls: add a boolean suboption that unlock path specification as list
Closed	marmoute	D10451 urlutil: move url "fixing" at the time of `ui.paths` initialization
Closed	marmoute	D10450 path: teach the `hg path` command to display boolean sub-option
Closed	marmoute	D10449 parselist: move the function from config to stringutil
Closed	marmoute	D10448 bookmark: use `list_paths` to access path definition
Closed	marmoute	D10447 urlutil: make `paths` class old list of `path`
Closed	marmoute	D10446 urlutil: extract `chain_path` in a function
Closed	marmoute	D10445 urlutil: add a `copy` method to `path
Closed	marmoute	D10444 template: add a `paths` field to all entry in peerurls
Closed	marmoute	D10443 template: make an explicit closure for formatting entry in peerurls
Closed	marmoute	D10442 template: use `list_paths` in `peerurls`
Closed	marmoute	D10441 paths: use `list_paths` in `hg paths`
Closed	marmoute	D10440 urlutil: introduce a new `list_paths` function
Closed	marmoute	D10439 urlutil: deprecate `getpath`
Closed	marmoute	D10438 urlutil: inline the relevant part of `getpath` in `get_push_paths`
Closed	marmoute	D10437 url_util: introduce a `try_path` function
Abandoned	marmoute	D10436 perfphasesremote: use `get_unique_push_path` if available
Closed	marmoute	D10435 revset: drop an outdated comment
Closed	marmoute	D10432 ui: deprecated `ui.expandpath`
Closed	marmoute	D10431 urlutil: remove usage of `ui.expandpath` in `get_clone_path`
Closed	marmoute	D10430 urlutil: remove usage of `ui.expandpath` in `get_unique_pull_path`
Closed	marmoute	D10429 urlutil: remove usage of `ui.expandpath` in `get_pull_paths`
Closed	marmoute	D10428 debugbackupbundle: use `get_unique_pull_path`
Closed	marmoute	D10427 debugssl: use `get_unique_pull_path`
Closed	marmoute	D10426 debugdiscovery: use `get_unique_pull_path`
Closed	marmoute	D10425 profiling: use `util.expandpath` instead of `ui.expandpath` for output
Closed	marmoute	D10424 dispatch: use the new API to resolve --repository
Closed	marmoute	D10423 perf-discovery: use `get_unique_pull_path`
Closed	marmoute	D10422 revset: use `get_unique_pull_path` for `remote(…)`
Closed	marmoute	D10421 remotefilelog: use `get_unique_pull_path` in `getflogheads`
Closed	marmoute	D10420 summary: use the new APIs
Closed	marmoute	D10419 share: use `get_clone_path`
Closed	marmoute	D10418 init: use `get_clone_path` when suitable
Closed	marmoute	D10417 clone: use `get_clone_path`
Closed	marmoute	D10416 incoming: kill the `repo._subtoppath =` hack
Closed	marmoute	D10415 identify: use `get_unique_pull_path`
Closed	marmoute	D10414 bundle: support multiple destinations
Closed	marmoute	D10413 lfs: use the new APIs
Closed	marmoute	D10412 fastannotate: use `get_unique_pull_path`
Closed	marmoute	D10411 remotefilelog: use the right expandpath in to expand `~`
Closed	marmoute	D10410 transplant: use `get_unique_pull_path`
Closed	marmoute	D10456 infinitepush: use `get_unique_pull_path`
Closed	marmoute	D10409 relink: use `get_unique_pull_path`
Closed	marmoute	D10408 histedit: use `get_unique_push_path`
Closed	marmoute	D10407 urlutil: add a new `get_unique_push_path`
Closed	marmoute	D10406 fetch: use `get_unique_pull_path` to retrieve the path
Closed	marmoute	D10405 patchbomb: use `get_unique_pull_path`
Closed	marmoute	D10404 narrow: use `get_unique_pull_path`
Closed	marmoute	D10403 urlutil: add a new `get_unique_pull_path`
Closed	marmoute	D10402 mq: use the new `get_clone_path` to get the remote url
Closed	marmoute	D10401 urlutil: add a `get_clone_path` function
Closed	marmoute	D10393 outgoing: use `get_push_paths` in the revset too
Closed	marmoute	D10392 incoming: use `urlutil.get_pull_paths`
Closed	marmoute	D10391 outgoing: accept multiple destinations
Closed	marmoute	D10390 outgoing: pass subrepo path using function argument instead of abssource hack
Closed	marmoute	D10434 subrepo: introduce a `repo_rel_or_abs_source` function

Diff 27205

mercurial/utils/urlutil.py

	@pathsuboption(b'pushrev', b'pushrev')			@pathsuboption(b'pushrev', b'pushrev')
	def pushrevpathoption(ui, path, value):			def pushrevpathoption(ui, path, value):
	return value			return value


	class path(object):			class path(object):
	"""Represents an individual path and its configuration."""			"""Represents an individual path and its configuration."""

	def __init__(self, ui, name, rawloc=None, suboptions=None):			def __init__(self, ui=None, name=None, rawloc=None, suboptions=None):
	"""Construct a path from its config options.			"""Construct a path from its config options.

	``ui`` is the ``ui`` instance the path is coming from.			``ui`` is the ``ui`` instance the path is coming from.
	``name`` is the symbolic name of the path.			``name`` is the symbolic name of the path.
	``rawloc`` is the raw location, as defined in the config.			``rawloc`` is the raw location, as defined in the config.
	``pushloc`` is the raw locations pushes should be made to.			``pushloc`` is the raw locations pushes should be made to.

	If ``name`` is not defined, we require that the location be a) a local			If ``name`` is not defined, we require that the location be a) a local
	filesystem path with a .hg directory or b) a URL. If not,			filesystem path with a .hg directory or b) a URL. If not,
	``ValueError`` is raised.			``ValueError`` is raised.
	"""			"""
				if ui is None:
				pulkitUnsubmitted Not Done Hm, can we prevent this hack somehow? Having an `empty` argument seems like one option to me. pulkit: Hm, can we prevent this hack somehow? Having an `empty` argument seems like one option to me.
				marmouteAuthorUnsubmitted Done I am not sure what you suggest here. Can you elaborate ? (not sure about what part you find hacky either) marmoute: I am not sure what you suggest here. Can you elaborate ? (not sure about what part you find…
				# used in copy
				assert name is None
				assert rawloc is None
				assert suboptions is None
				return

	if not rawloc:			if not rawloc:
	raise ValueError(b'rawloc must be defined')			raise ValueError(b'rawloc must be defined')

	# Locations may define branches via syntax <base>#<branch>.			# Locations may define branches via syntax <base>#<branch>.
	u = url(rawloc)			u = url(rawloc)
	branch = None			branch = None
	if u.fragment:			if u.fragment:
	branch = u.fragment			branch = u.fragment
	self.branch = subpath.branch			self.branch = subpath.branch
	else:			else:
	base = self.rawloc.rsplit(b'#', 1)[0]			base = self.rawloc.rsplit(b'#', 1)[0]
	self.rawloc = b'%s#%s' % (base, self.branch)			self.rawloc = b'%s#%s' % (base, self.branch)
	suboptions = subpath._all_sub_opts.copy()			suboptions = subpath._all_sub_opts.copy()
	suboptions.update(self._own_sub_opts)			suboptions.update(self._own_sub_opts)
	self._apply_suboptions(ui, suboptions)			self._apply_suboptions(ui, suboptions)

				def copy(self):
				"""make a copy of this path object"""
				new = self.__class__()
				for k, v in self.__dict__.items():
				new_copy = getattr(v, 'copy', None)
				if new_copy is not None:
				v = new_copy()
				new.__dict__[k] = v
				return new

	def _validate_path(self):			def _validate_path(self):
	# When given a raw location but not a symbolic name, validate the			# When given a raw location but not a symbolic name, validate the
	# location is valid.			# location is valid.
	if (			if (
	not self.name			not self.name
	and not self.url.scheme			and not self.url.scheme
	and not self._isvalidlocalpath(self.loc)			and not self._isvalidlocalpath(self.loc)
	):			):

This is an archive of the discontinued Mercurial Phabricator instance.

urlutil: add a `copy` method to `pathClosedPublic

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 27205

mercurial/utils/urlutil.py

urlutil: add a `copy` method to `path
ClosedPublic

Revision Contents
Changeset List