| indygreg | |
| Alphare |
| hg-reviewers |
See comment for details. We will need to fix the test coverage when this
incompatibility is lifted.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| Path | Packages | |||
|---|---|---|---|---|
| M | mercurial/revlog.py (12 lines) |
| # inline are not yet supported because they suffer from an issue when | # inline are not yet supported because they suffer from an issue when | ||||
| # rewriting them (since it's not an append-only operation). | # rewriting them (since it's not an append-only operation). | ||||
| # See issue6485. | # See issue6485. | ||||
| assert not self._inline | assert not self._inline | ||||
| if not helpers[1] and not helpers[2]: | if not helpers[1] and not helpers[2]: | ||||
| # Nothing to generate or remove | # Nothing to generate or remove | ||||
| return | return | ||||
| # changelog implement some "delayed" writing mechanism that assume that | |||||
| # all index data is writen in append mode and is therefor incompatible | |||||
| # with the seeked write done in this method. The use of such "delayed" | |||||
| # writing will soon be removed for revlog version that support side | |||||
| # data, so for now, we only keep this simple assert to highlight the | |||||
| # situation. | |||||
| delayed = getattr(self, '_delayed', False) | |||||
| diverted = getattr(self, '_divert', False) | |||||
| if delayed and not diverted: | |||||
| msg = "cannot rewrite_sidedata of a delayed revlog" | |||||
| raise error.ProgrammingError(msg) | |||||
| new_entries = [] | new_entries = [] | ||||
| # append the new sidedata | # append the new sidedata | ||||
| with self._datafp(b'a+') as fp: | with self._datafp(b'a+') as fp: | ||||
| # Maybe this bug still exists, see revlog._writeentry | # Maybe this bug still exists, see revlog._writeentry | ||||
| fp.seek(0, os.SEEK_END) | fp.seek(0, os.SEEK_END) | ||||
| current_offset = fp.tell() | current_offset = fp.tell() | ||||
| for rev in range(startrev, endrev + 1): | for rev in range(startrev, endrev + 1): | ||||
| entry = self.index[rev] | entry = self.index[rev] | ||||