( )⚙ D10596 revlog: rename `versionflags` to header

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10596

revlog: rename `versionflags` to header
ClosedPublic

Authored by marmoute on May 3 2021, 7:50 AM.

Details

Reviewers
indygreg
Alphare
Group Reviewers
hg-reviewers
Commits
rHG6e0ee1810fbd: revlog: rename `versionflags` to header
Summary

The variable is named as such because it contains "version" information and
"flags" information. However you mostly needs to know the code to understand the
name which is not great. The fact that this is the very first four bytes in all
revlog seems more relevant, so we rename the variable "header".

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.May 3 2021, 7:50 AM
baymax updated this revision to Diff 27511.May 3 2021, 9:44 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Alphare accepted this revision.May 11 2021, 10:09 AM
This revision is now accepted and ready to land.May 11 2021, 10:09 AM
marmoute added a commit: rHG6e0ee1810fbd: revlog: rename `versionflags` to header.May 11 2021, 1:11 PM
Closed by commit rHG6e0ee1810fbd: revlog: rename `versionflags` to header (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/revlog.py (14 lines)

Diff 27373

mercurial/revlog.py

self._indexfile = index_file self._indexfile = index_file
self._datafile = data_file self._datafile = data_file
indexdata = b'' indexdata = b''
self._initempty = True self._initempty = True
indexdata = self._get_data(self._indexfile, mmapindexthreshold) indexdata = self._get_data(self._indexfile, mmapindexthreshold)
if len(indexdata) > 0: if len(indexdata) > 0:
versionflags = INDEX_HEADER.unpack(indexdata[:4])[0] header = INDEX_HEADER.unpack(indexdata[:4])[0]
self._initempty = False self._initempty = False
else: else:
versionflags = newversionflags header = newversionflags
flags = self._format_flags = versionflags & ~0xFFFF flags = self._format_flags = header & ~0xFFFF
fmt = self._format_version = versionflags & 0xFFFF fmt = self._format_version = header & 0xFFFF
if fmt == REVLOGV0: if fmt == REVLOGV0:
if flags: if flags:
raise error.RevlogError( raise error.RevlogError(
_(b'unknown flags (%#04x) in version %d revlog %s') _(b'unknown flags (%#04x) in version %d revlog %s')
% (flags >> 16, fmt, self.display_id) % (flags >> 16, fmt, self.display_id)
) )
self._inline = False self._inline = False
self._generaldelta = False self._generaldelta = False
elif fmt == REVLOGV1: elif fmt == REVLOGV1:
if flags & ~REVLOGV1_FLAGS: if flags & ~REVLOGV1_FLAGS:
raise error.RevlogError( raise error.RevlogError(
_(b'unknown flags (%#04x) in version %d revlog %s') _(b'unknown flags (%#04x) in version %d revlog %s')
% (flags >> 16, fmt, self.display_id) % (flags >> 16, fmt, self.display_id)
) )
self._inline = versionflags & FLAG_INLINE_DATA self._inline = header & FLAG_INLINE_DATA
self._generaldelta = versionflags & FLAG_GENERALDELTA self._generaldelta = header & FLAG_GENERALDELTA
elif fmt == REVLOGV2: elif fmt == REVLOGV2:
if flags & ~REVLOGV2_FLAGS: if flags & ~REVLOGV2_FLAGS:
raise error.RevlogError( raise error.RevlogError(
_(b'unknown flags (%#04x) in version %d revlog %s') _(b'unknown flags (%#04x) in version %d revlog %s')
% (flags >> 16, fmt, self.display_id) % (flags >> 16, fmt, self.display_id)
) )