( )⚙ D10596 revlog: rename `versionflags` to header

This is an archive of the discontinued Mercurial Phabricator instance.

revlog: rename `versionflags` to header
ClosedPublic

Authored by marmoute on May 3 2021, 7:50 AM.

Details

Summary

The variable is named as such because it contains "version" information and
"flags" information. However you mostly needs to know the code to understand the
name which is not great. The fact that this is the very first four bytes in all
revlog seems more relevant, so we rename the variable "header".

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.May 3 2021, 7:50 AM
baymax updated this revision to Diff 27511.May 3 2021, 9:44 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Alphare accepted this revision.May 11 2021, 10:09 AM
This revision is now accepted and ready to land.May 11 2021, 10:09 AM
This revision was automatically updated to reflect the committed changes.