This is an archive of the discontinued Mercurial Phabricator instance.

Differential D10598

revlog: use `_format_flags` to access flags instead of `header`
ClosedPublic

Authored by marmoute on May 3 2021, 7:51 AM.

Details

Reviewers
indygreg
Alphare
Group Reviewers
hg-reviewers
Commits
rHG93c2e6cdbd01: revlog: use `_format_flags` to access flags instead of `header`
Summary

It seems better to reuse the variable we carefully extracted

This also open the way to more flexible way to retrieve these flags.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.May 3 2021, 7:51 AM
baymax updated this revision to Diff 27513.May 3 2021, 9:44 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Alphare accepted this revision.May 11 2021, 10:09 AM
This revision is now accepted and ready to land.May 11 2021, 10:09 AM

Revision Contents
Changeset List

PathPackages
Mmercurial/revlog.py (4 lines)

Diff 27844

mercurial/revlog.py

elif fmt == REVLOGV1: elif fmt == REVLOGV1:
if flags & ~REVLOGV1_FLAGS: if flags & ~REVLOGV1_FLAGS:
raise error.RevlogError( raise error.RevlogError(
_(b'unknown flags (%#04x) in version %d revlog %s') _(b'unknown flags (%#04x) in version %d revlog %s')
% (flags >> 16, fmt, self.display_id) % (flags >> 16, fmt, self.display_id)
) )
self._inline = header & FLAG_INLINE_DATA self._inline = self._format_flags & FLAG_INLINE_DATA
self._generaldelta = header & FLAG_GENERALDELTA self._generaldelta = self._format_flags & FLAG_GENERALDELTA
elif fmt == REVLOGV2: elif fmt == REVLOGV2:
if flags & ~REVLOGV2_FLAGS: if flags & ~REVLOGV2_FLAGS:
raise error.RevlogError( raise error.RevlogError(
_(b'unknown flags (%#04x) in version %d revlog %s') _(b'unknown flags (%#04x) in version %d revlog %s')
% (flags >> 16, fmt, self.display_id) % (flags >> 16, fmt, self.display_id)
) )