This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11082

dummyssh: use subprocess instead of os.call
ClosedPublic

Authored by marmoute on Jul 11 2021, 5:37 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG119673fb37aa: dummyssh: use subprocess instead of os.call
Summary

Welcome in 2020

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jul 11 2021, 5:37 PM
Alphare accepted this revision.Jul 13 2021, 12:18 PM
This revision is now accepted and ready to land.Jul 13 2021, 12:18 PM
marmoute added a commit: rHG119673fb37aa: dummyssh: use subprocess instead of os.call.Jul 16 2021, 6:39 AM
Closed by commit rHG119673fb37aa: dummyssh: use subprocess instead of os.call (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.
pulkit added a subscriber: pulkit.Jul 20 2021, 3:25 PM

2021 it is but yeah ;)

Revision Contents
Changeset List

PathPackages
Mtests/dummyssh (3 lines)

Diff 29330

tests/dummyssh

#!/usr/bin/env python3 #!/usr/bin/env python3
from __future__ import absolute_import from __future__ import absolute_import
import os import os
import subprocess
import sys import sys
os.chdir(os.getenv('TESTTMP')) os.chdir(os.getenv('TESTTMP'))
if sys.argv[1] != "user@dummy": if sys.argv[1] != "user@dummy":
sys.exit(-1) sys.exit(-1)
os.environ["SSH_CLIENT"] = "%s 1 2" % os.environ.get('LOCALIP', '127.0.0.1') os.environ["SSH_CLIENT"] = "%s 1 2" % os.environ.get('LOCALIP', '127.0.0.1')
log = open("dummylog", "ab") log = open("dummylog", "ab")
log.write(b"Got arguments") log.write(b"Got arguments")
for i, arg in enumerate(sys.argv[1:]): for i, arg in enumerate(sys.argv[1:]):
log.write(b" %d:%s" % (i + 1, arg.encode('latin1'))) log.write(b" %d:%s" % (i + 1, arg.encode('latin1')))
log.write(b"\n") log.write(b"\n")
log.close() log.close()
hgcmd = sys.argv[2] hgcmd = sys.argv[2]
if os.name == 'nt': if os.name == 'nt':
# hack to make simple unix single quote quoting work on windows # hack to make simple unix single quote quoting work on windows
hgcmd = hgcmd.replace("'", '"') hgcmd = hgcmd.replace("'", '"')
r = os.system(hgcmd) r = subprocess.call(hgcmd, shell=True)
sys.exit(bool(r)) sys.exit(bool(r))