( )⚙ D12037 test-http-bad-server: rename config to use `-`

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D12037

test-http-bad-server: rename config to use `-`
ClosedPublic

Authored by marmoute on Jan 24 2022, 9:44 AM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHGee1235afda4b: test-http-bad-server: rename config to use `-`
Summary

This make things much more readable.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jan 24 2022, 9:44 AM
Alphare accepted this revision.Jan 24 2022, 9:51 AM
This revision is now accepted and ready to land.Jan 24 2022, 9:51 AM
marmoute added a commit: rHGee1235afda4b: test-http-bad-server: rename config to use `-`.Jan 25 2022, 4:17 AM
Closed by commit rHGee1235afda4b: test-http-bad-server: rename config to use `-` (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 31913

tests/test-http-bad-server.t

> [extensions] > [extensions]
> badserver = $TESTDIR/testlib/badserverext.py > badserver = $TESTDIR/testlib/badserverext.py
> [server] > [server]
> compressionengines = none > compressionengines = none
> EOF > EOF
Failure to accept() socket should result in connection related error message Failure to accept() socket should result in connection related error message
$ hg serve --config badserver.closebeforeaccept=true -p $HGPORT -d --pid-file=hg.pid $ hg serve --config badserver.close-before-accept=true -p $HGPORT -d --pid-file=hg.pid
$ cat hg.pid > $DAEMON_PIDS $ cat hg.pid > $DAEMON_PIDS
$ hg clone http://localhost:$HGPORT/ clone $ hg clone http://localhost:$HGPORT/ clone
abort: error: (\$ECONNRESET\$|\$EADDRNOTAVAIL\$) (re) abort: error: (\$ECONNRESET\$|\$EADDRNOTAVAIL\$) (re)
[100] [100]
(The server exits on its own, but there is a race between that and starting a new server. (The server exits on its own, but there is a race between that and starting a new server.
So ensure the process is dead.) So ensure the process is dead.)
$ killdaemons.py $DAEMON_PIDS $ killdaemons.py $DAEMON_PIDS
Failure immediately after accept() should yield connection related error message Failure immediately after accept() should yield connection related error message
$ hg serve --config badserver.closeafteraccept=true -p $HGPORT -d --pid-file=hg.pid $ hg serve --config badserver.close-after-accept=true -p $HGPORT -d --pid-file=hg.pid
$ cat hg.pid > $DAEMON_PIDS $ cat hg.pid > $DAEMON_PIDS
TODO: this usually outputs good results, but sometimes emits abort: TODO: this usually outputs good results, but sometimes emits abort:
error: '' on FreeBSD and OS X. error: '' on FreeBSD and OS X.
What we ideally want are: What we ideally want are:
abort: error: $ECONNRESET$ abort: error: $ECONNRESET$
The flakiness in this output was observable easily with The flakiness in this output was observable easily with
--runs-per-test=20 on macOS 10.12 during the freeze for 4.2. --runs-per-test=20 on macOS 10.12 during the freeze for 4.2.
$ hg clone http://localhost:$HGPORT/ clone $ hg clone http://localhost:$HGPORT/ clone
abort: error: * (glob) abort: error: * (glob)
[100] [100]
$ killdaemons.py $DAEMON_PIDS $ killdaemons.py $DAEMON_PIDS
Failure to read all bytes in initial HTTP request should yield connection related error message Failure to read all bytes in initial HTTP request should yield connection related error message
$ hg serve --config badserver.closeafterrecvbytes=1 -p $HGPORT -d --pid-file=hg.pid -E error.log $ hg serve --config badserver.close-after-recv-bytes=1 -p $HGPORT -d --pid-file=hg.pid -E error.log
$ cat hg.pid > $DAEMON_PIDS $ cat hg.pid > $DAEMON_PIDS
$ hg clone http://localhost:$HGPORT/ clone $ hg clone http://localhost:$HGPORT/ clone
abort: error: bad HTTP status line: * (glob) abort: error: bad HTTP status line: * (glob)
[100] [100]
$ killdaemons.py $DAEMON_PIDS $ killdaemons.py $DAEMON_PIDS
$ cat error.log $ cat error.log
readline(1 from 65537) -> (1) G readline(1 from 65537) -> (1) G
read limit reached; closing socket read limit reached; closing socket
$ rm -f error.log $ rm -f error.log
Same failure, but server reads full HTTP request line Same failure, but server reads full HTTP request line
$ hg serve --config badserver.closeafterrecvbytes=40 -p $HGPORT -d --pid-file=hg.pid -E error.log $ hg serve --config badserver.close-after-recv-bytes=40 -p $HGPORT -d --pid-file=hg.pid -E error.log
$ cat hg.pid > $DAEMON_PIDS $ cat hg.pid > $DAEMON_PIDS
$ hg clone http://localhost:$HGPORT/ clone $ hg clone http://localhost:$HGPORT/ clone
abort: error: bad HTTP status line: * (glob) abort: error: bad HTTP status line: * (glob)
[100] [100]
$ killdaemons.py $DAEMON_PIDS $ killdaemons.py $DAEMON_PIDS
$ cat error.log $ cat error.log
readline(40 from 65537) -> (33) GET /?cmd=capabilities HTTP/1.1\r\n readline(40 from 65537) -> (33) GET /?cmd=capabilities HTTP/1.1\r\n
readline(7 from *) -> (7) Accept- (glob) readline(7 from *) -> (7) Accept- (glob)
read limit reached; closing socket read limit reached; closing socket
$ rm -f error.log $ rm -f error.log
Failure on subsequent HTTP request on the same socket (cmd?batch) Failure on subsequent HTTP request on the same socket (cmd?batch)
$ hg serve --config badserver.closeafterrecvbytes=210,223 -p $HGPORT -d --pid-file=hg.pid -E error.log $ hg serve --config badserver.close-after-recv-bytes=210,223 -p $HGPORT -d --pid-file=hg.pid -E error.log
$ cat hg.pid > $DAEMON_PIDS $ cat hg.pid > $DAEMON_PIDS
$ hg clone http://localhost:$HGPORT/ clone $ hg clone http://localhost:$HGPORT/ clone
abort: error: bad HTTP status line: * (glob) abort: error: bad HTTP status line: * (glob)
[100] [100]
$ killdaemons.py $DAEMON_PIDS $ killdaemons.py $DAEMON_PIDS
$ cat error.log $ cat error.log
readline(39 from *) -> (35) accept: application/mercurial-0.1\r\n (glob) readline(39 from *) -> (35) accept: application/mercurial-0.1\r\n (glob)
readline(4 from *) -> (4) host (glob) readline(4 from *) -> (4) host (glob)
read limit reached; closing socket read limit reached; closing socket
$ rm -f error.log $ rm -f error.log
Failure to read getbundle HTTP request Failure to read getbundle HTTP request
$ hg serve --config badserver.closeafterrecvbytes=308,317,304 -p $HGPORT -d --pid-file=hg.pid -E error.log $ hg serve --config badserver.close-after-recv-bytes=308,317,304 -p $HGPORT -d --pid-file=hg.pid -E error.log
$ cat hg.pid > $DAEMON_PIDS $ cat hg.pid > $DAEMON_PIDS
$ hg clone http://localhost:$HGPORT/ clone $ hg clone http://localhost:$HGPORT/ clone
requesting all changes requesting all changes
abort: error: bad HTTP status line: * (glob) abort: error: bad HTTP status line: * (glob)
[100] [100]
$ killdaemons.py $DAEMON_PIDS $ killdaemons.py $DAEMON_PIDS
readline(247 from *) -> (29) vary: X-HgArg-1,X-HgProto-1\r\n (glob) readline(247 from *) -> (29) vary: X-HgArg-1,X-HgProto-1\r\n (glob)
readline(218 from *) -> (218) x-hgarg-1: bookmarks=1&bundlecaps=HG20%2Cbundle2%3DHG20%250Abookmarks%250Achangegroup%253D01%252C02%250Adigests%253Dmd5%252Csha1%252Csha512%250Aerror%253Dabort%252Cunsupportedcontent%252Cpushraced%252Cpushkey%250Ahgtag (glob) readline(218 from *) -> (218) x-hgarg-1: bookmarks=1&bundlecaps=HG20%2Cbundle2%3DHG20%250Abookmarks%250Achangegroup%253D01%252C02%250Adigests%253Dmd5%252Csha1%252Csha512%250Aerror%253Dabort%252Cunsupportedcontent%252Cpushraced%252Cpushkey%250Ahgtag (glob)
read limit reached; closing socket read limit reached; closing socket
$ rm -f error.log $ rm -f error.log
Now do a variation using POST to send arguments Now do a variation using POST to send arguments
$ hg serve --config experimental.httppostargs=true --config badserver.closeafterrecvbytes=329,344 -p $HGPORT -d --pid-file=hg.pid -E error.log $ hg serve --config experimental.httppostargs=true --config badserver.close-after-recv-bytes=329,344 -p $HGPORT -d --pid-file=hg.pid -E error.log
$ cat hg.pid > $DAEMON_PIDS $ cat hg.pid > $DAEMON_PIDS
$ hg clone http://localhost:$HGPORT/ clone $ hg clone http://localhost:$HGPORT/ clone
abort: error: bad HTTP status line: * (glob) abort: error: bad HTTP status line: * (glob)
[100] [100]
$ killdaemons.py $DAEMON_PIDS $ killdaemons.py $DAEMON_PIDS
write(36) -> HTTP/1.1 500 Internal Server Error\r\n (no-py3 !) write(36) -> HTTP/1.1 500 Internal Server Error\r\n (no-py3 !)
$ rm -f error.log $ rm -f error.log
Now move on to partial server responses Now move on to partial server responses
Server sends a single character from the HTTP response line Server sends a single character from the HTTP response line
$ hg serve --config badserver.closeaftersendbytes=1 -p $HGPORT -d --pid-file=hg.pid -E error.log $ hg serve --config badserver.close-after-send-bytes=1 -p $HGPORT -d --pid-file=hg.pid -E error.log
$ cat hg.pid > $DAEMON_PIDS $ cat hg.pid > $DAEMON_PIDS
$ hg clone http://localhost:$HGPORT/ clone $ hg clone http://localhost:$HGPORT/ clone
abort: error: bad HTTP status line: H abort: error: bad HTTP status line: H
[100] [100]
$ killdaemons.py $DAEMON_PIDS $ killdaemons.py $DAEMON_PIDS
write(286) -> HTTP/1.1 200 Script output follows\r\nServer: badhttpserver\r\nDate: $HTTP_DATE$\r\nContent-Type: application/mercurial-0.1\r\nContent-Length: 431\r\n\r\nHTTP/1.1 500 Internal Server Error\r\nServer: badhttpserver\r\nDate: $HTTP_DATE$\r\nTransfer-Encoding: chunked\r\n\r\n (py3 no-py36 !) write(286) -> HTTP/1.1 200 Script output follows\r\nServer: badhttpserver\r\nDate: $HTTP_DATE$\r\nContent-Type: application/mercurial-0.1\r\nContent-Length: 431\r\n\r\nHTTP/1.1 500 Internal Server Error\r\nServer: badhttpserver\r\nDate: $HTTP_DATE$\r\nTransfer-Encoding: chunked\r\n\r\n (py3 no-py36 !)
write(36) -> HTTP/1.1 500 Internal Server Error\r\n (no-py3 !) write(36) -> HTTP/1.1 500 Internal Server Error\r\n (no-py3 !)
$ rm -f error.log $ rm -f error.log
Server sends an incomplete capabilities response body Server sends an incomplete capabilities response body
$ hg serve --config badserver.closeaftersendbytes=180 -p $HGPORT -d --pid-file=hg.pid -E error.log $ hg serve --config badserver.close-after-send-bytes=180 -p $HGPORT -d --pid-file=hg.pid -E error.log
$ cat hg.pid > $DAEMON_PIDS $ cat hg.pid > $DAEMON_PIDS
$ hg clone http://localhost:$HGPORT/ clone $ hg clone http://localhost:$HGPORT/ clone
abort: HTTP request error (incomplete response; expected 431 bytes got 20) abort: HTTP request error (incomplete response; expected 431 bytes got 20)
(this may be an intermittent network failure; if the error persists, consider contacting the network or server operator) (this may be an intermittent network failure; if the error persists, consider contacting the network or server operator)
[255] [255]
$ killdaemons.py $DAEMON_PIDS $ killdaemons.py $DAEMON_PIDS
Traceback (most recent call last): Traceback (most recent call last):
Exception: connection closed after sending N bytes Exception: connection closed after sending N bytes
$ rm -f error.log $ rm -f error.log
Server sends incomplete headers for batch request Server sends incomplete headers for batch request
$ hg serve --config badserver.closeaftersendbytes=709 -p $HGPORT -d --pid-file=hg.pid -E error.log $ hg serve --config badserver.close-after-send-bytes=709 -p $HGPORT -d --pid-file=hg.pid -E error.log
$ cat hg.pid > $DAEMON_PIDS $ cat hg.pid > $DAEMON_PIDS
TODO this output is horrible TODO this output is horrible
$ hg clone http://localhost:$HGPORT/ clone $ hg clone http://localhost:$HGPORT/ clone
abort: 'http://localhost:$HGPORT/' does not appear to be an hg repository: abort: 'http://localhost:$HGPORT/' does not appear to be an hg repository:
---%<--- (applicat) ---%<--- (applicat)
write(285) -> HTTP/1.1 200 Script output follows\r\nServer: badhttpserver\r\nDate: $HTTP_DATE$\r\nContent-Type: application/mercurial-0.1\r\nContent-Length: 42\r\n\r\nHTTP/1.1 500 Internal Server Error\r\nServer: badhttpserver\r\nDate: $HTTP_DATE$\r\nTransfer-Encoding: chunked\r\n\r\n (py3 no-py36 !) write(285) -> HTTP/1.1 200 Script output follows\r\nServer: badhttpserver\r\nDate: $HTTP_DATE$\r\nContent-Type: application/mercurial-0.1\r\nContent-Length: 42\r\n\r\nHTTP/1.1 500 Internal Server Error\r\nServer: badhttpserver\r\nDate: $HTTP_DATE$\r\nTransfer-Encoding: chunked\r\n\r\n (py3 no-py36 !)
write(36) -> HTTP/1.1 500 Internal Server Error\r\n (no-py3 !) write(36) -> HTTP/1.1 500 Internal Server Error\r\n (no-py3 !)
$ rm -f error.log $ rm -f error.log
Server sends an incomplete HTTP response body to batch request Server sends an incomplete HTTP response body to batch request
$ hg serve --config badserver.closeaftersendbytes=774 -p $HGPORT -d --pid-file=hg.pid -E error.log $ hg serve --config badserver.close-after-send-bytes=774 -p $HGPORT -d --pid-file=hg.pid -E error.log
$ cat hg.pid > $DAEMON_PIDS $ cat hg.pid > $DAEMON_PIDS
TODO client spews a stack due to uncaught ValueError in batch.results() TODO client spews a stack due to uncaught ValueError in batch.results()
#if no-chg #if no-chg
$ hg clone http://localhost:$HGPORT/ clone 2> /dev/null $ hg clone http://localhost:$HGPORT/ clone 2> /dev/null
[1] [1]
#else #else
$ hg clone http://localhost:$HGPORT/ clone 2> /dev/null $ hg clone http://localhost:$HGPORT/ clone 2> /dev/null
Traceback (most recent call last): Traceback (most recent call last):
Exception: connection closed after sending N bytes Exception: connection closed after sending N bytes
$ rm -f error.log $ rm -f error.log
Server sends incomplete headers for getbundle response Server sends incomplete headers for getbundle response
$ hg serve --config badserver.closeaftersendbytes=921 -p $HGPORT -d --pid-file=hg.pid -E error.log $ hg serve --config badserver.close-after-send-bytes=921 -p $HGPORT -d --pid-file=hg.pid -E error.log
$ cat hg.pid > $DAEMON_PIDS $ cat hg.pid > $DAEMON_PIDS
TODO this output is terrible TODO this output is terrible
$ hg clone http://localhost:$HGPORT/ clone $ hg clone http://localhost:$HGPORT/ clone
requesting all changes requesting all changes
abort: 'http://localhost:$HGPORT/' does not appear to be an hg repository: abort: 'http://localhost:$HGPORT/' does not appear to be an hg repository:
---%<--- (application/mercuri) ---%<--- (application/mercuri)
write(293) -> HTTP/1.1 200 Script output follows\r\nServer: badhttpserver\r\nDate: $HTTP_DATE$\r\nContent-Type: application/mercurial-0.2\r\nTransfer-Encoding: chunked\r\n\r\nHTTP/1.1 500 Internal Server Error\r\nServer: badhttpserver\r\nDate: $HTTP_DATE$\r\nTransfer-Encoding: chunked\r\n\r\n (py3 no-py36 !) write(293) -> HTTP/1.1 200 Script output follows\r\nServer: badhttpserver\r\nDate: $HTTP_DATE$\r\nContent-Type: application/mercurial-0.2\r\nTransfer-Encoding: chunked\r\n\r\nHTTP/1.1 500 Internal Server Error\r\nServer: badhttpserver\r\nDate: $HTTP_DATE$\r\nTransfer-Encoding: chunked\r\n\r\n (py3 no-py36 !)
write(36) -> HTTP/1.1 500 Internal Server Error\r\n (no-py3 !) write(36) -> HTTP/1.1 500 Internal Server Error\r\n (no-py3 !)
$ rm -f error.log $ rm -f error.log
Server stops before it sends transfer encoding Server stops before it sends transfer encoding
$ hg serve --config badserver.closeaftersendbytes=954 -p $HGPORT -d --pid-file=hg.pid -E error.log $ hg serve --config badserver.close-after-send-bytes=954 -p $HGPORT -d --pid-file=hg.pid -E error.log
$ cat hg.pid > $DAEMON_PIDS $ cat hg.pid > $DAEMON_PIDS
$ hg clone http://localhost:$HGPORT/ clone $ hg clone http://localhost:$HGPORT/ clone
requesting all changes requesting all changes
abort: stream ended unexpectedly (got 0 bytes, expected 1) abort: stream ended unexpectedly (got 0 bytes, expected 1)
[255] [255]
$ killdaemons.py $DAEMON_PIDS $ killdaemons.py $DAEMON_PIDS
write(293) -> HTTP/1.1 200 Script output follows\r\nServer: badhttpserver\r\nDate: $HTTP_DATE$\r\nContent-Type: application/mercurial-0.2\r\nTransfer-Encoding: chunked\r\n\r\nHTTP/1.1 500 Internal Server Error\r\nServer: badhttpserver\r\nDate: $HTTP_DATE$\r\nTransfer-Encoding: chunked\r\n\r\n (py3 !) write(293) -> HTTP/1.1 200 Script output follows\r\nServer: badhttpserver\r\nDate: $HTTP_DATE$\r\nContent-Type: application/mercurial-0.2\r\nTransfer-Encoding: chunked\r\n\r\nHTTP/1.1 500 Internal Server Error\r\nServer: badhttpserver\r\nDate: $HTTP_DATE$\r\nTransfer-Encoding: chunked\r\n\r\n (py3 !)
write(36) -> HTTP/1.1 500 Internal Server Error\r\n (no-py3 !) write(36) -> HTTP/1.1 500 Internal Server Error\r\n (no-py3 !)
#endif #endif
$ rm -f error.log $ rm -f error.log
Server sends empty HTTP body for getbundle Server sends empty HTTP body for getbundle
$ hg serve --config badserver.closeaftersendbytes=959 -p $HGPORT -d --pid-file=hg.pid -E error.log $ hg serve --config badserver.close-after-send-bytes=959 -p $HGPORT -d --pid-file=hg.pid -E error.log
$ cat hg.pid > $DAEMON_PIDS $ cat hg.pid > $DAEMON_PIDS
$ hg clone http://localhost:$HGPORT/ clone $ hg clone http://localhost:$HGPORT/ clone
requesting all changes requesting all changes
abort: HTTP request error (incomplete response) abort: HTTP request error (incomplete response)
(this may be an intermittent network failure; if the error persists, consider contacting the network or server operator) (this may be an intermittent network failure; if the error persists, consider contacting the network or server operator)
[255] [255]
write(293) -> HTTP/1.1 200 Script output follows\r\nServer: badhttpserver\r\nDate: $HTTP_DATE$\r\nContent-Type: application/mercurial-0.2\r\nTransfer-Encoding: chunked\r\n\r\nHTTP/1.1 500 Internal Server Error\r\nServer: badhttpserver\r\nDate: $HTTP_DATE$\r\nTransfer-Encoding: chunked\r\n\r\n (py3 no-py36 !) write(293) -> HTTP/1.1 200 Script output follows\r\nServer: badhttpserver\r\nDate: $HTTP_DATE$\r\nContent-Type: application/mercurial-0.2\r\nTransfer-Encoding: chunked\r\n\r\nHTTP/1.1 500 Internal Server Error\r\nServer: badhttpserver\r\nDate: $HTTP_DATE$\r\nTransfer-Encoding: chunked\r\n\r\n (py3 no-py36 !)
write(36) -> HTTP/1.1 500 Internal Server Error\r\n (no-py3 !) write(36) -> HTTP/1.1 500 Internal Server Error\r\n (no-py3 !)
$ rm -f error.log $ rm -f error.log
Server sends partial compression string Server sends partial compression string
$ hg serve --config badserver.closeaftersendbytes=983 -p $HGPORT -d --pid-file=hg.pid -E error.log $ hg serve --config badserver.close-after-send-bytes=983 -p $HGPORT -d --pid-file=hg.pid -E error.log
$ cat hg.pid > $DAEMON_PIDS $ cat hg.pid > $DAEMON_PIDS
$ hg clone http://localhost:$HGPORT/ clone $ hg clone http://localhost:$HGPORT/ clone
requesting all changes requesting all changes
abort: HTTP request error (incomplete response) abort: HTTP request error (incomplete response)
(this may be an intermittent network failure; if the error persists, consider contacting the network or server operator) (this may be an intermittent network failure; if the error persists, consider contacting the network or server operator)
[255] [255]
Exception: connection closed after sending N bytes Exception: connection closed after sending N bytes
write(27) -> 15\r\nInternal Server Error\r\n (no-py3 !) write(27) -> 15\r\nInternal Server Error\r\n (no-py3 !)
$ rm -f error.log $ rm -f error.log
Server sends partial bundle2 header magic Server sends partial bundle2 header magic
$ hg serve --config badserver.closeaftersendbytes=980 -p $HGPORT -d --pid-file=hg.pid -E error.log $ hg serve --config badserver.close-after-send-bytes=980 -p $HGPORT -d --pid-file=hg.pid -E error.log
$ cat hg.pid > $DAEMON_PIDS $ cat hg.pid > $DAEMON_PIDS
$ hg clone http://localhost:$HGPORT/ clone $ hg clone http://localhost:$HGPORT/ clone
requesting all changes requesting all changes
abort: HTTP request error (incomplete response) (py3 !) abort: HTTP request error (incomplete response) (py3 !)
abort: HTTP request error (incomplete response; expected 4 bytes got 3) (no-py3 !) abort: HTTP request error (incomplete response; expected 4 bytes got 3) (no-py3 !)
(this may be an intermittent network failure; if the error persists, consider contacting the network or server operator) (this may be an intermittent network failure; if the error persists, consider contacting the network or server operator)
[255] [255]
write(27) -> 15\r\nInternal Server Error\r\n write(27) -> 15\r\nInternal Server Error\r\n
#endif #endif
$ rm -f error.log $ rm -f error.log
Server sends incomplete bundle2 stream params length Server sends incomplete bundle2 stream params length
$ hg serve --config badserver.closeaftersendbytes=989 -p $HGPORT -d --pid-file=hg.pid -E error.log $ hg serve --config badserver.close-after-send-bytes=989 -p $HGPORT -d --pid-file=hg.pid -E error.log
$ cat hg.pid > $DAEMON_PIDS $ cat hg.pid > $DAEMON_PIDS
$ hg clone http://localhost:$HGPORT/ clone $ hg clone http://localhost:$HGPORT/ clone
requesting all changes requesting all changes
abort: HTTP request error (incomplete response) (py3 !) abort: HTTP request error (incomplete response) (py3 !)
abort: HTTP request error (incomplete response; expected 4 bytes got 3) (no-py3 !) abort: HTTP request error (incomplete response; expected 4 bytes got 3) (no-py3 !)
(this may be an intermittent network failure; if the error persists, consider contacting the network or server operator) (this may be an intermittent network failure; if the error persists, consider contacting the network or server operator)
[255] [255]
write(27) -> 15\r\nInternal Server Error\r\n write(27) -> 15\r\nInternal Server Error\r\n
#endif #endif
$ rm -f error.log $ rm -f error.log
Servers stops after bundle2 stream params header Servers stops after bundle2 stream params header
$ hg serve --config badserver.closeaftersendbytes=992 -p $HGPORT -d --pid-file=hg.pid -E error.log $ hg serve --config badserver.close-after-send-bytes=992 -p $HGPORT -d --pid-file=hg.pid -E error.log
$ cat hg.pid > $DAEMON_PIDS $ cat hg.pid > $DAEMON_PIDS
$ hg clone http://localhost:$HGPORT/ clone $ hg clone http://localhost:$HGPORT/ clone
requesting all changes requesting all changes
abort: HTTP request error (incomplete response) abort: HTTP request error (incomplete response)
(this may be an intermittent network failure; if the error persists, consider contacting the network or server operator) (this may be an intermittent network failure; if the error persists, consider contacting the network or server operator)
[255] [255]
write(27) -> 15\r\nInternal Server Error\r\n write(27) -> 15\r\nInternal Server Error\r\n
#endif #endif
$ rm -f error.log $ rm -f error.log
Server stops sending after bundle2 part header length Server stops sending after bundle2 part header length
$ hg serve --config badserver.closeaftersendbytes=1001 -p $HGPORT -d --pid-file=hg.pid -E error.log $ hg serve --config badserver.close-after-send-bytes=1001 -p $HGPORT -d --pid-file=hg.pid -E error.log
$ cat hg.pid > $DAEMON_PIDS $ cat hg.pid > $DAEMON_PIDS
$ hg clone http://localhost:$HGPORT/ clone $ hg clone http://localhost:$HGPORT/ clone
requesting all changes requesting all changes
abort: HTTP request error (incomplete response) abort: HTTP request error (incomplete response)
(this may be an intermittent network failure; if the error persists, consider contacting the network or server operator) (this may be an intermittent network failure; if the error persists, consider contacting the network or server operator)
[255] [255]
write(27) -> 15\r\nInternal Server Error\r\n write(27) -> 15\r\nInternal Server Error\r\n
#endif #endif
$ rm -f error.log $ rm -f error.log
Server stops sending after bundle2 part header Server stops sending after bundle2 part header
$ hg serve --config badserver.closeaftersendbytes=1048 -p $HGPORT -d --pid-file=hg.pid -E error.log $ hg serve --config badserver.close-after-send-bytes=1048 -p $HGPORT -d --pid-file=hg.pid -E error.log
$ cat hg.pid > $DAEMON_PIDS $ cat hg.pid > $DAEMON_PIDS
$ hg clone http://localhost:$HGPORT/ clone $ hg clone http://localhost:$HGPORT/ clone
requesting all changes requesting all changes
adding changesets adding changesets
transaction abort! transaction abort!
rollback completed rollback completed
abort: HTTP request error (incomplete response) abort: HTTP request error (incomplete response)
write(27) -> 15\r\nInternal Server Error\r\n write(27) -> 15\r\nInternal Server Error\r\n
#endif #endif
$ rm -f error.log $ rm -f error.log
Server stops after bundle2 part payload chunk size Server stops after bundle2 part payload chunk size
$ hg serve --config badserver.closeaftersendbytes=1069 -p $HGPORT -d --pid-file=hg.pid -E error.log $ hg serve --config badserver.close-after-send-bytes=1069 -p $HGPORT -d --pid-file=hg.pid -E error.log
$ cat hg.pid > $DAEMON_PIDS $ cat hg.pid > $DAEMON_PIDS
$ hg clone http://localhost:$HGPORT/ clone $ hg clone http://localhost:$HGPORT/ clone
requesting all changes requesting all changes
adding changesets adding changesets
transaction abort! transaction abort!
rollback completed rollback completed
abort: HTTP request error (incomplete response) (py3 !) abort: HTTP request error (incomplete response) (py3 !)
write(27) -> 15\r\nInternal Server Error\r\n write(27) -> 15\r\nInternal Server Error\r\n
#endif #endif
$ rm -f error.log $ rm -f error.log
Server stops sending in middle of bundle2 payload chunk Server stops sending in middle of bundle2 payload chunk
$ hg serve --config badserver.closeaftersendbytes=1530 -p $HGPORT -d --pid-file=hg.pid -E error.log $ hg serve --config badserver.close-after-send-bytes=1530 -p $HGPORT -d --pid-file=hg.pid -E error.log
$ cat hg.pid > $DAEMON_PIDS $ cat hg.pid > $DAEMON_PIDS
$ hg clone http://localhost:$HGPORT/ clone $ hg clone http://localhost:$HGPORT/ clone
requesting all changes requesting all changes
adding changesets adding changesets
transaction abort! transaction abort!
rollback completed rollback completed
abort: HTTP request error (incomplete response) abort: HTTP request error (incomplete response)
write(27) -> 15\r\nInternal Server Error\r\n write(27) -> 15\r\nInternal Server Error\r\n
#endif #endif
$ rm -f error.log $ rm -f error.log
Server stops sending after 0 length payload chunk size Server stops sending after 0 length payload chunk size
$ hg serve --config badserver.closeaftersendbytes=1561 -p $HGPORT -d --pid-file=hg.pid -E error.log $ hg serve --config badserver.close-after-send-bytes=1561 -p $HGPORT -d --pid-file=hg.pid -E error.log
$ cat hg.pid > $DAEMON_PIDS $ cat hg.pid > $DAEMON_PIDS
$ hg clone http://localhost:$HGPORT/ clone $ hg clone http://localhost:$HGPORT/ clone
requesting all changes requesting all changes
adding changesets adding changesets
adding manifests adding manifests
adding file changes adding file changes
transaction abort! transaction abort!
write(27) -> 15\r\nInternal Server Error\r\n write(27) -> 15\r\nInternal Server Error\r\n
#endif #endif
$ rm -f error.log $ rm -f error.log
Server stops sending after 0 part bundle part header (indicating end of bundle2 payload) Server stops sending after 0 part bundle part header (indicating end of bundle2 payload)
This is before the 0 size chunked transfer part that signals end of HTTP response. This is before the 0 size chunked transfer part that signals end of HTTP response.
$ hg serve --config badserver.closeaftersendbytes=1736 -p $HGPORT -d --pid-file=hg.pid -E error.log $ hg serve --config badserver.close-after-send-bytes=1736 -p $HGPORT -d --pid-file=hg.pid -E error.log
$ cat hg.pid > $DAEMON_PIDS $ cat hg.pid > $DAEMON_PIDS
$ hg clone http://localhost:$HGPORT/ clone $ hg clone http://localhost:$HGPORT/ clone
requesting all changes requesting all changes
adding changesets adding changesets
adding manifests adding manifests
adding file changes adding file changes
added 1 changesets with 1 changes to 1 files added 1 changesets with 1 changes to 1 files
write(27) -> 15\r\nInternal Server Error\r\n write(27) -> 15\r\nInternal Server Error\r\n
#endif #endif
$ rm -f error.log $ rm -f error.log
$ rm -rf clone $ rm -rf clone
Server sends a size 0 chunked-transfer size without terminating \r\n Server sends a size 0 chunked-transfer size without terminating \r\n
$ hg serve --config badserver.closeaftersendbytes=1739 -p $HGPORT -d --pid-file=hg.pid -E error.log $ hg serve --config badserver.close-after-send-bytes=1739 -p $HGPORT -d --pid-file=hg.pid -E error.log
$ cat hg.pid > $DAEMON_PIDS $ cat hg.pid > $DAEMON_PIDS
$ hg clone http://localhost:$HGPORT/ clone $ hg clone http://localhost:$HGPORT/ clone
requesting all changes requesting all changes
adding changesets adding changesets
adding manifests adding manifests
adding file changes adding file changes
added 1 changesets with 1 changes to 1 files added 1 changesets with 1 changes to 1 files

tests/testlib/badserverext.py

# badserverext.py - Extension making servers behave badly # badserverext.py - Extension making servers behave badly
# #
# Copyright 2017 Gregory Szorc <gregory.szorc@gmail.com> # Copyright 2017 Gregory Szorc <gregory.szorc@gmail.com>
# #
# This software may be used and distributed according to the terms of the # This software may be used and distributed according to the terms of the
# GNU General Public License version 2 or any later version. # GNU General Public License version 2 or any later version.
# no-check-code # no-check-code
"""Extension to make servers behave badly. """Extension to make servers behave badly.
This extension is useful for testing Mercurial behavior when various network This extension is useful for testing Mercurial behavior when various network
events occur. events occur.
Various config options in the [badserver] section influence behavior: Various config options in the [badserver] section influence behavior:
closebeforeaccept close-before-accept
If true, close() the server socket when a new connection arrives before If true, close() the server socket when a new connection arrives before
accept() is called. The server will then exit. accept() is called. The server will then exit.
closeafteraccept close-after-accept
If true, the server will close() the client socket immediately after If true, the server will close() the client socket immediately after
accept(). accept().
closeafterrecvbytes close-after-recv-bytes
If defined, close the client socket after receiving this many bytes. If defined, close the client socket after receiving this many bytes.
closeaftersendbytes close-after-send-bytes
If defined, close the client socket after sending this many bytes. If defined, close the client socket after sending this many bytes.
""" """
from __future__ import absolute_import from __future__ import absolute_import
import socket import socket
from mercurial import ( from mercurial import (
pycompat, pycompat,
registrar, registrar,
) )
from mercurial.hgweb import server from mercurial.hgweb import server
configtable = {} configtable = {}
configitem = registrar.configitem(configtable) configitem = registrar.configitem(configtable)
configitem( configitem(
b'badserver', b'badserver',
b'closeafteraccept', b'close-after-accept',
default=False, default=False,
) )
configitem( configitem(
b'badserver', b'badserver',
b'closeafterrecvbytes', b'close-after-recv-bytes',
default=b'0', default=b'0',
) )
configitem( configitem(
b'badserver', b'badserver',
b'closeaftersendbytes', b'close-after-send-bytes',
default=b'0', default=b'0',
) )
configitem( configitem(
b'badserver', b'badserver',
b'closebeforeaccept', b'close-before-accept',
default=False, default=False,
) )
# We can't adjust __class__ on a socket instance. So we define a proxy type. # We can't adjust __class__ on a socket instance. So we define a proxy type.
class socketproxy(object): class socketproxy(object):
__slots__ = ( __slots__ = (
'_orig', '_orig',
'_logfp', '_logfp',
def extsetup(ui): def extsetup(ui):
# Change the base HTTP server class so various events can be performed. # Change the base HTTP server class so various events can be performed.
# See SocketServer.BaseServer for how the specially named methods work. # See SocketServer.BaseServer for how the specially named methods work.
class badserver(server.MercurialHTTPServer): class badserver(server.MercurialHTTPServer):
def __init__(self, ui, *args, **kwargs): def __init__(self, ui, *args, **kwargs):
self._ui = ui self._ui = ui
super(badserver, self).__init__(ui, *args, **kwargs) super(badserver, self).__init__(ui, *args, **kwargs)
recvbytes = self._ui.config(b'badserver', b'closeafterrecvbytes') recvbytes = self._ui.config(b'badserver', b'close-after-recv-bytes')
recvbytes = recvbytes.split(b',') recvbytes = recvbytes.split(b',')
self.closeafterrecvbytes = [int(v) for v in recvbytes if v] self.closeafterrecvbytes = [int(v) for v in recvbytes if v]
sendbytes = self._ui.config(b'badserver', b'closeaftersendbytes') sendbytes = self._ui.config(b'badserver', b'close-after-send-bytes')
sendbytes = sendbytes.split(b',') sendbytes = sendbytes.split(b',')
self.closeaftersendbytes = [int(v) for v in sendbytes if v] self.closeaftersendbytes = [int(v) for v in sendbytes if v]
# Need to inherit object so super() works. # Need to inherit object so super() works.
class badrequesthandler(self.RequestHandlerClass, object): class badrequesthandler(self.RequestHandlerClass, object):
def send_header(self, name, value): def send_header(self, name, value):
# Make headers deterministic to facilitate testing. # Make headers deterministic to facilitate testing.
if name.lower() == 'date': if name.lower() == 'date':
value = 'Fri, 14 Apr 2017 00:00:00 GMT' value = 'Fri, 14 Apr 2017 00:00:00 GMT'
elif name.lower() == 'server': elif name.lower() == 'server':
value = 'badhttpserver' value = 'badhttpserver'
return super(badrequesthandler, self).send_header( return super(badrequesthandler, self).send_header(
name, value name, value
) )
self.RequestHandlerClass = badrequesthandler self.RequestHandlerClass = badrequesthandler
# Called to accept() a pending socket. # Called to accept() a pending socket.
def get_request(self): def get_request(self):
if self._ui.configbool(b'badserver', b'closebeforeaccept'): if self._ui.configbool(b'badserver', b'close-before-accept'):
self.socket.close() self.socket.close()
# Tells the server to stop processing more requests. # Tells the server to stop processing more requests.
self.__shutdown_request = True self.__shutdown_request = True
# Simulate failure to stop processing this request. # Simulate failure to stop processing this request.
raise socket.error('close before accept') raise socket.error('close before accept')
if self._ui.configbool(b'badserver', b'closeafteraccept'): if self._ui.configbool(b'badserver', b'close-after-accept'):
request, client_address = super(badserver, self).get_request() request, client_address = super(badserver, self).get_request()
request.close() request.close()
raise socket.error('close after accept') raise socket.error('close after accept')
return super(badserver, self).get_request() return super(badserver, self).get_request()
# Does heavy lifting of processing a request. Invokes # Does heavy lifting of processing a request. Invokes
# self.finish_request() which calls self.RequestHandlerClass() which # self.finish_request() which calls self.RequestHandlerClass() which