( )⚙ D12073 test-http-bad-server: use the new pattern-reading for a test-case

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D12073

test-http-bad-server: use the new pattern-reading for a test-case
ClosedPublic

Authored by marmoute on Jan 24 2022, 9:49 AM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG009e86022a9d: test-http-bad-server: use the new pattern-reading for a test-case
Summary

This test case is now less sensitive to change of unrelated bits of the
client/server exchange.

Since this introduce some churn in the output, we do it independently for each
test cases. This patch is the last of such changes, for both sent and recv
cases.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Jan 24 2022, 9:49 AM
Alphare accepted this revision.Jan 24 2022, 10:51 AM
This revision is now accepted and ready to land.Jan 24 2022, 10:51 AM
Alphare requested changes to this revision.Jan 24 2022, 10:53 AM
This revision now requires changes to proceed.Jan 24 2022, 10:53 AM
Alphare accepted this revision.Jan 24 2022, 10:53 AM
This revision is now accepted and ready to land.Jan 24 2022, 10:53 AM
baymax updated this revision to Diff 31897.Jan 24 2022, 1:20 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Revision Contents
Changeset List

PathPackages
Mtests/test-http-bad-server.t (54 lines)

Diff 31776

tests/test-http-bad-server.t

readline(218 from *) -> (218) x-hgarg-1: bookmarks=1&bundlecaps=HG20%2Cbundle2%3DHG20%250Abookmarks%250Achangegroup%253D01%252C02%250Adigests%253Dmd5%252Csha1%252Csha512%250Aerror%253Dabort%252Cunsupportedcontent%252Cpushraced%252Cpushkey%250Ahgtag (glob) readline(218 from *) -> (218) x-hgarg-1: bookmarks=1&bundlecaps=HG20%2Cbundle2%3DHG20%250Abookmarks%250Achangegroup%253D01%252C02%250Adigests%253Dmd5%252Csha1%252Csha512%250Aerror%253Dabort%252Cunsupportedcontent%252Cpushraced%252Cpushkey%250Ahgtag (glob)
read limit reached; closing socket read limit reached; closing socket
$ rm -f error.log $ rm -f error.log
Now do a variation using POST to send arguments Now do a variation using POST to send arguments
=============================================== ===============================================
$ hg serve --config experimental.httppostargs=true --config badserver.close-after-recv-bytes=329,344 -p $HGPORT -d --pid-file=hg.pid -E error.log $ hg serve \
> --config badserver.close-after-recv-patterns="x-hgargs-post:,user-agent: mercurial/proto-1.0" \
> --config badserver.close-after-recv-bytes="14,26" \
> --config experimental.httppostargs=true \
> -p $HGPORT -d --pid-file=hg.pid -E error.log
$ cat hg.pid > $DAEMON_PIDS $ cat hg.pid > $DAEMON_PIDS
$ hg clone http://localhost:$HGPORT/ clone $ hg clone http://localhost:$HGPORT/ clone
abort: error: bad HTTP status line: * (glob) abort: error: bad HTTP status line: * (glob)
[100] [100]
$ killdaemons.py $DAEMON_PIDS $ killdaemons.py $DAEMON_PIDS
$ cat error.log | "$PYTHON" $TESTDIR/filtertraceback.py $ cat error.log | "$PYTHON" $TESTDIR/filtertraceback.py
readline(329 from ~) -> (33) GET /?cmd=capabilities HTTP/1.1\r\n readline(~) -> (33) GET /?cmd=capabilities HTTP/1.1\r\n
readline(296 from *) -> (27) Accept-Encoding: identity\r\n (glob) readline(*) -> (27) Accept-Encoding: identity\r\n (glob)
readline(269 from *) -> (35) accept: application/mercurial-0.1\r\n (glob) readline(*) -> (35) accept: application/mercurial-0.1\r\n (glob)
readline(234 from *) -> (2?) host: localhost:$HGPORT\r\n (glob) readline(*) -> (2?) host: localhost:$HGPORT\r\n (glob)
readline(* from *) -> (49) user-agent: mercurial/proto-1.0 (Mercurial 4.2)\r\n (glob) readline(*) -> (49) user-agent: mercurial/proto-1.0 (Mercurial 4.2)\r\n (glob)
readline(* from *) -> (2) \r\n (glob) readline(*) -> (2) \r\n (glob)
sendall(160) -> HTTP/1.1 200 Script output follows\r\nServer: badhttpserver\r\nDate: $HTTP_DATE$\r\nContent-Type: application/mercurial-0.1\r\nContent-Length: 444\r\n\r\n (py36 !) sendall(160) -> HTTP/1.1 200 Script output follows\r\nServer: badhttpserver\r\nDate: $HTTP_DATE$\r\nContent-Type: application/mercurial-0.1\r\nContent-Length: 444\r\n\r\n (py36 !)
sendall(444) -> batch branchmap $USUAL_BUNDLE2_CAPS_NO_PHASES$ changegroupsubset compression=none getbundle httpheader=1024 httpmediatype=0.1rx,0.1tx,0.2tx httppostargs known lookup pushkey streamreqs=generaldelta,revlogv1 unbundle=HG10GZ,HG10BZ,HG10UN unbundlehash (py36 !) sendall(444) -> batch branchmap $USUAL_BUNDLE2_CAPS_NO_PHASES$ changegroupsubset compression=none getbundle httpheader=1024 httpmediatype=0.1rx,0.1tx,0.2tx httppostargs known lookup pushkey streamreqs=generaldelta,revlogv1 unbundle=HG10GZ,HG10BZ,HG10UN unbundlehash (py36 !)
write(160) -> HTTP/1.1 200 Script output follows\r\nServer: badhttpserver\r\nDate: $HTTP_DATE$\r\nContent-Type: application/mercurial-0.1\r\nContent-Length: 444\r\n\r\n (py3 no-py36 !) write(160) -> HTTP/1.1 200 Script output follows\r\nServer: badhttpserver\r\nDate: $HTTP_DATE$\r\nContent-Type: application/mercurial-0.1\r\nContent-Length: 444\r\n\r\n (py3 no-py36 !)
write(444) -> batch branchmap $USUAL_BUNDLE2_CAPS_NO_PHASES$ changegroupsubset compression=none getbundle httpheader=1024 httpmediatype=0.1rx,0.1tx,0.2tx httppostargs known lookup pushkey streamreqs=generaldelta,revlogv1 unbundle=HG10GZ,HG10BZ,HG10UN unbundlehash (py3 no-py36 !) write(444) -> batch branchmap $USUAL_BUNDLE2_CAPS_NO_PHASES$ changegroupsubset compression=none getbundle httpheader=1024 httpmediatype=0.1rx,0.1tx,0.2tx httppostargs known lookup pushkey streamreqs=generaldelta,revlogv1 unbundle=HG10GZ,HG10BZ,HG10UN unbundlehash (py3 no-py36 !)
write(36) -> HTTP/1.1 200 Script output follows\r\n (no-py3 !) write(36) -> HTTP/1.1 200 Script output follows\r\n (no-py3 !)
write(23) -> Server: badhttpserver\r\n (no-py3 !) write(23) -> Server: badhttpserver\r\n (no-py3 !)
write(37) -> Date: $HTTP_DATE$\r\n (no-py3 !) write(37) -> Date: $HTTP_DATE$\r\n (no-py3 !)
write(41) -> Content-Type: application/mercurial-0.1\r\n (no-py3 !) write(41) -> Content-Type: application/mercurial-0.1\r\n (no-py3 !)
write(21) -> Content-Length: 444\r\n (no-py3 !) write(21) -> Content-Length: 444\r\n (no-py3 !)
write(2) -> \r\n (no-py3 !) write(2) -> \r\n (no-py3 !)
write(444) -> batch branchmap $USUAL_BUNDLE2_CAPS_NO_PHASES$ changegroupsubset compression=none getbundle httpheader=1024 httpmediatype=0.1rx,0.1tx,0.2tx httppostargs known lookup pushkey streamreqs=generaldelta,revlogv1 unbundle=HG10GZ,HG10BZ,HG10UN unbundlehash (no-py3 !) write(444) -> batch branchmap $USUAL_BUNDLE2_CAPS_NO_PHASES$ changegroupsubset compression=none getbundle httpheader=1024 httpmediatype=0.1rx,0.1tx,0.2tx httppostargs known lookup pushkey streamreqs=generaldelta,revlogv1 unbundle=HG10GZ,HG10BZ,HG10UN unbundlehash (no-py3 !)
readline(1?? from ~) -> (27) POST /?cmd=batch HTTP/1.1\r\n (glob) readline(~) -> (27) POST /?cmd=batch HTTP/1.1\r\n (glob)
readline(1?? from *) -> (27) Accept-Encoding: identity\r\n (glob) readline(*) -> (27) Accept-Encoding: identity\r\n (glob)
readline(1?? from *) -> (41) content-type: application/mercurial-0.1\r\n (glob) readline(*) -> (41) content-type: application/mercurial-0.1\r\n (glob)
readline(6? from *) -> (33) vary: X-HgArgs-Post,X-HgProto-1\r\n (glob) readline(*) -> (33) vary: X-HgArgs-Post,X-HgProto-1\r\n (glob)
readline(3? from *) -> (19) x-hgargs-post: 28\r\n (glob) readline(*) -> (19) x-hgargs-post: 28\r\n (glob)
readline(1? from *) -> (1?) x-hgproto-1: * (glob) readline(*) -> (1?) x-hgproto-1: * (glob)
read limit reached; closing socket read limit reached; closing socket
readline(344 from ~) -> (27) POST /?cmd=batch HTTP/1.1\r\n readline(~) -> (27) POST /?cmd=batch HTTP/1.1\r\n
readline(317 from *) -> (27) Accept-Encoding: identity\r\n (glob) readline(*) -> (27) Accept-Encoding: identity\r\n (glob)
readline(290 from *) -> (41) content-type: application/mercurial-0.1\r\n (glob) readline(*) -> (41) content-type: application/mercurial-0.1\r\n (glob)
readline(249 from *) -> (33) vary: X-HgArgs-Post,X-HgProto-1\r\n (glob) readline(*) -> (33) vary: X-HgArgs-Post,X-HgProto-1\r\n (glob)
readline(216 from *) -> (19) x-hgargs-post: 28\r\n (glob) readline(*) -> (19) x-hgargs-post: 28\r\n (glob)
readline(197 from *) -> (61) x-hgproto-1: 0.1 0.2 comp=$USUAL_COMPRESSIONS$ partial-pull\r\n (glob) readline(*) -> (61) x-hgproto-1: 0.1 0.2 comp=$USUAL_COMPRESSIONS$ partial-pull\r\n (glob)
readline(136 from *) -> (35) accept: application/mercurial-0.1\r\n (glob) readline(*) -> (35) accept: application/mercurial-0.1\r\n (glob)
readline(101 from *) -> (20) content-length: 28\r\n (glob) readline(*) -> (20) content-length: 28\r\n (glob)
readline(81 from *) -> (*) host: localhost:$HGPORT\r\n (glob) readline(*) -> (*) host: localhost:$HGPORT\r\n (glob)
readline(* from *) -> (49) user-agent: mercurial/proto-1.0 (Mercurial 4.2)\r\n (glob) readline(*) -> (49) user-agent: mercurial/proto-1.0 (Mercurial 4.2)\r\n (glob)
readline(* from *) -> (2) \r\n (glob) readline(*) -> (2) \r\n (glob)
read(* from 28) -> (*) cmds=* (glob) read(24 from 28) -> (*) cmds=* (glob)
read limit reached; closing socket read limit reached; closing socket
$LOCALIP - - [$ERRDATE$] Exception happened during processing request '/?cmd=batch': (glob) $LOCALIP - - [$ERRDATE$] Exception happened during processing request '/?cmd=batch': (glob)
Traceback (most recent call last): Traceback (most recent call last):
Exception: connection closed after receiving N bytes Exception: connection closed after receiving N bytes
write(126) -> HTTP/1.1 500 Internal Server Error\r\nServer: badhttpserver\r\nDate: $HTTP_DATE$\r\nTransfer-Encoding: chunked\r\n\r\n (py3 no-py36 !) write(126) -> HTTP/1.1 500 Internal Server Error\r\nServer: badhttpserver\r\nDate: $HTTP_DATE$\r\nTransfer-Encoding: chunked\r\n\r\n (py3 no-py36 !)
$ rm -f error.log $ rm -f error.log