This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2137

py3: use raw string for file open mode
ClosedPublic

Authored by indygreg on Feb 11 2018, 5:57 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG788b2e8530ae: py3: use raw string for file open mode
Summary

Otherwise the module importer rewrites it to bytes on Python 3,
which angers Python 3.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Feb 11 2018, 5:57 PM
Closed by commit rHG788b2e8530ae: py3: use raw string for file open mode (authored by indygreg). · Explain WhyFeb 11 2018, 8:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/archival.py (2 lines)

Diff 5438

mercurial/archival.py

or compressed with deflate.''' or compressed with deflate.'''
def __init__(self, dest, mtime, compress=True): def __init__(self, dest, mtime, compress=True):
if not isinstance(dest, str): if not isinstance(dest, str):
try: try:
dest.tell() dest.tell()
except (AttributeError, IOError): except (AttributeError, IOError):
dest = tellable(dest) dest = tellable(dest)
self.z = zipfile.ZipFile(dest, 'w', self.z = zipfile.ZipFile(dest, r'w',
compress and zipfile.ZIP_DEFLATED or compress and zipfile.ZIP_DEFLATED or
zipfile.ZIP_STORED) zipfile.ZIP_STORED)
# Python's zipfile module emits deprecation warnings if we try # Python's zipfile module emits deprecation warnings if we try
# to store files with a date before 1980. # to store files with a date before 1980.
epoch = 315532800 # calendar.timegm((1980, 1, 1, 0, 0, 0, 1, 1, 0)) epoch = 315532800 # calendar.timegm((1980, 1, 1, 0, 0, 0, 1, 1, 0))
if mtime < epoch: if mtime < epoch:
mtime = epoch mtime = epoch