This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2138

run-tests: report tests that exception occurred in
ClosedPublic

Authored by indygreg on Feb 11 2018, 5:57 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG8de90e006c78: run-tests: report tests that exception occurred in
Summary

We now record the test that an exception occurred in. We put this
information to use by aggregating the count of failures in each
test. For each exception, the exception report now prints the total
number of tests having that exception and the test with the least
number of exceptions exhibiting that failure. The exception list
is now sorted by (total count, tests impacted, count of failures
in least failing test).

This allows us to:

  • Assess how widespread a failure is. Some exceptions occur a lot in a few tests. Others occur over many tests.
  • Easily run a test exhibiting an exception without having to find a failure in test output.
  • Find and fix low hanging fruit (e.g. exceptions that are the only failure in a test).

Here's an example of the new output:

199 (4 tests) /home/gps/src/hg/hgext/blackbox.py:191: %b requires a bytes-like object, or an object that implements bytes, not 'str' (test-devel-warnings.t - 1 total)
142 (19 tests) /home/gps/src/hg/hgext/mq.py:655: list indices must be integers or slices, not bytes (test-hardlinks.t - 1 total)
140 (20 tests) /home/gps/src/hg/mercurial/patch.py:296: string argument expected, got 'bytes' (test-audit-subrepo.t - 1 total)
101 (15 tests) /home/gps/src/hg/hgext/convert/convcmd.py:60: encode() argument 1 must be str, not bytes (test-convert-clonebranches.t - 1 total)
90 (2 tests) /home/gps/src/hg/hgext/mq.py:456: can't concat str to bytes (test-mq-qqueue.t - 1 total)
87 (2 tests) /home/gps/src/hg/mercurial/branchmap.py:380: %b requires a bytes-like object, or an object that implements bytes, not 'FileNotFoundError' (test-branches.t - 2 total)
85 (22 tests) /home/gps/src/hg/mercurial/sshpeer.py:223: cannot convert 'UUID' object to bytes (test-bundle2-pushback.t - 1 total)
1 (1 tests) /home/gps/src/hg/mercurial/formatter.py:254: %b requires a bytes-like object, or an object that implements bytes, not 'str' (test-debugextensions.t - 2 total)
1 (1 tests) /home/gps/src/hg/hgext/convert/convcmd.py:420: startswith first arg must be str or a tuple of str, not bytes (test-convert-authormap.t - 2 total)
1 (1 tests) /home/gps/src/hg/mercurial/revlog.py:797: '>=' not supported between instances of 'NoneType' and 'int' (test-unionrepo.t - 1 total)
1 (1 tests) /home/gps/src/hg/hgext/show.py:129: %b requires a bytes-like object, or an object that implements bytes, not 'str' (test-show.t - 1 total)

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Feb 11 2018, 5:57 PM
Closed by commit rHG8de90e006c78: run-tests: report tests that exception occurred in (authored by indygreg). · Explain WhyFeb 11 2018, 8:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/logexceptions.py (1 line)
Mtests/run-tests.py (64 lines)

Diff 5439

tests/logexceptions.py

primaryframe = '%s:%d' % (primary.filename, primary.lineno) primaryframe = '%s:%d' % (primary.filename, primary.lineno)
with open(dest, 'wb') as fh: with open(dest, 'wb') as fh:
parts = [ parts = [
str(exc_value), str(exc_value),
primaryframe, primaryframe,
hgframe, hgframe,
hgline, hgline,
ui.environ[b'TESTNAME'].decode('utf-8', 'replace'),
] ]
fh.write(b'\0'.join(p.encode('utf-8', 'replace') for p in parts)) fh.write(b'\0'.join(p.encode('utf-8', 'replace') for p in parts))
def extsetup(ui): def extsetup(ui):
extensions.wrapfunction(dispatch, 'handlecommandexception', extensions.wrapfunction(dispatch, 'handlecommandexception',
handleexception) handleexception)

tests/run-tests.py

"""Obtain environment variables to use during test execution.""" """Obtain environment variables to use during test execution."""
def defineport(i): def defineport(i):
offset = '' if i == 0 else '%s' % i offset = '' if i == 0 else '%s' % i
env["HGPORT%s" % offset] = '%s' % (self._startport + i) env["HGPORT%s" % offset] = '%s' % (self._startport + i)
env = os.environ.copy() env = os.environ.copy()
env['PYTHONUSERBASE'] = sysconfig.get_config_var('userbase') or '' env['PYTHONUSERBASE'] = sysconfig.get_config_var('userbase') or ''
env['HGEMITWARNINGS'] = '1' env['HGEMITWARNINGS'] = '1'
env['TESTTMP'] = self._testtmp env['TESTTMP'] = self._testtmp
env['TESTNAME'] = self.name
env['HOME'] = self._testtmp env['HOME'] = self._testtmp
# This number should match portneeded in _getport # This number should match portneeded in _getport
for port in xrange(3): for port in xrange(3):
# This list should be parallel to _portmap in _getreplacements # This list should be parallel to _portmap in _getreplacements
defineport(port) defineport(port)
env["HGRCPATH"] = os.path.join(self._threadtmp, b'.hgrc') env["HGRCPATH"] = os.path.join(self._threadtmp, b'.hgrc')
env["DAEMON_PIDS"] = os.path.join(self._threadtmp, b'daemon.pids') env["DAEMON_PIDS"] = os.path.join(self._threadtmp, b'daemon.pids')
env["HGEDITOR"] = ('"' + sys.executable + '"' env["HGEDITOR"] = ('"' + sys.executable + '"'
self.stream.writeln('python hash seed: %s' % self.stream.writeln('python hash seed: %s' %
os.environ['PYTHONHASHSEED']) os.environ['PYTHONHASHSEED'])
if self._runner.options.time: if self._runner.options.time:
self.printtimes(result.times) self.printtimes(result.times)
if self._runner.options.exceptions: if self._runner.options.exceptions:
exceptions = aggregateexceptions( exceptions = aggregateexceptions(
os.path.join(self._runner._outputdir, b'exceptions')) os.path.join(self._runner._outputdir, b'exceptions'))
total = sum(exceptions.values())
self.stream.writeln('Exceptions Report:') self.stream.writeln('Exceptions Report:')
self.stream.writeln('%d total from %d frames' % self.stream.writeln('%d total from %d frames' %
(total, len(exceptions))) (exceptions['total'],
for (frame, line, exc), count in exceptions.most_common(): len(exceptions['exceptioncounts'])))
self.stream.writeln('%d\t%s: %s' % (count, frame, exc)) combined = exceptions['combined']
for key in sorted(combined, key=combined.get, reverse=True):
frame, line, exc = key
totalcount, testcount, leastcount, leasttest = combined[key]
self.stream.writeln('%d (%d tests)\t%s: %s (%s - %d total)'
% (totalcount,
testcount,
frame, exc,
leasttest, leastcount))
self.stream.flush() self.stream.flush()
return result return result
def _bisecttests(self, tests): def _bisecttests(self, tests):
bisectcmd = ['hg', 'bisect'] bisectcmd = ['hg', 'bisect']
bisectrepo = self._runner.options.bisect_repo bisectrepo = self._runner.options.bisect_repo
found = self._findprogram(p) found = self._findprogram(p)
if found: if found:
vlog("# Found prerequisite", p, "at", found) vlog("# Found prerequisite", p, "at", found)
else: else:
print("WARNING: Did not find prerequisite tool: %s " % print("WARNING: Did not find prerequisite tool: %s " %
p.decode("utf-8")) p.decode("utf-8"))
def aggregateexceptions(path): def aggregateexceptions(path):
exceptions = collections.Counter() exceptioncounts = collections.Counter()
testsbyfailure = collections.defaultdict(set)
failuresbytest = collections.defaultdict(set)
for f in os.listdir(path): for f in os.listdir(path):
with open(os.path.join(path, f), 'rb') as fh: with open(os.path.join(path, f), 'rb') as fh:
data = fh.read().split(b'\0') data = fh.read().split(b'\0')
if len(data) != 4: if len(data) != 5:
continue continue
exc, mainframe, hgframe, hgline = data exc, mainframe, hgframe, hgline, testname = data
exc = exc.decode('utf-8') exc = exc.decode('utf-8')
mainframe = mainframe.decode('utf-8') mainframe = mainframe.decode('utf-8')
hgframe = hgframe.decode('utf-8') hgframe = hgframe.decode('utf-8')
hgline = hgline.decode('utf-8') hgline = hgline.decode('utf-8')
exceptions[(hgframe, hgline, exc)] += 1 testname = testname.decode('utf-8')
return exceptions key = (hgframe, hgline, exc)
exceptioncounts[key] += 1
testsbyfailure[key].add(testname)
failuresbytest[testname].add(key)
# Find test having fewest failures for each failure.
leastfailing = {}
for key, tests in testsbyfailure.items():
fewesttest = None
fewestcount = 99999999
for test in sorted(tests):
if len(failuresbytest[test]) < fewestcount:
fewesttest = test
fewestcount = len(failuresbytest[test])
leastfailing[key] = (fewestcount, fewesttest)
# Create a combined counter so we can sort by total occurrences and
# impacted tests.
combined = {}
for key in exceptioncounts:
combined[key] = (exceptioncounts[key],
len(testsbyfailure[key]),
leastfailing[key][0],
leastfailing[key][1])
return {
'exceptioncounts': exceptioncounts,
'total': sum(exceptioncounts.values()),
'combined': combined,
'leastfailing': leastfailing,
'byfailure': testsbyfailure,
'bytest': failuresbytest,
}
if __name__ == '__main__': if __name__ == '__main__':
runner = TestRunner() runner = TestRunner()
try: try:
import msvcrt import msvcrt
msvcrt.setmode(sys.stdin.fileno(), os.O_BINARY) msvcrt.setmode(sys.stdin.fileno(), os.O_BINARY)
msvcrt.setmode(sys.stdout.fileno(), os.O_BINARY) msvcrt.setmode(sys.stdout.fileno(), os.O_BINARY)
msvcrt.setmode(sys.stderr.fileno(), os.O_BINARY) msvcrt.setmode(sys.stderr.fileno(), os.O_BINARY)
except ImportError: except ImportError:
pass pass
sys.exit(runner.run(sys.argv[1:])) sys.exit(runner.run(sys.argv[1:]))