This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2778

tests: add test for a wire protocol request to wrong base URL
ClosedPublic

Authored by indygreg on Mar 10 2018, 3:03 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHG2859c6fa4fc2: tests: add test for a wire protocol request to wrong base URL
Summary

We have code that validates that wire protocol commands (which are
specified via query string) must occur at the base URL of a repo.
But we have no test coverage for this behavior. Let's add some.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Mar 10 2018, 3:03 PM
durin42 accepted this revision.Mar 12 2018, 5:00 PM
This revision is now accepted and ready to land.Mar 12 2018, 5:00 PM
Closed by commit rHG2859c6fa4fc2: tests: add test for a wire protocol request to wrong base URL (authored by indygreg). · Explain WhyMar 12 2018, 5:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-hgweb-commands.t (13 lines)

Diff 6836

tests/test-hgweb-commands.t

capabilities capabilities
$ get-with-headers.py $LOCALIP:$HGPORT '?cmd=capabilities'; echo $ get-with-headers.py $LOCALIP:$HGPORT '?cmd=capabilities'; echo
200 Script output follows 200 Script output follows
lookup branchmap pushkey known getbundle unbundlehash batch changegroupsubset $USUAL_BUNDLE2_CAPS_SERVER$ unbundle=HG10GZ,HG10BZ,HG10UN httpheader=1024 httpmediatype=0.1rx,0.1tx,0.2tx compression=$BUNDLE2_COMPRESSIONS$ lookup branchmap pushkey known getbundle unbundlehash batch changegroupsubset $USUAL_BUNDLE2_CAPS_SERVER$ unbundle=HG10GZ,HG10BZ,HG10UN httpheader=1024 httpmediatype=0.1rx,0.1tx,0.2tx compression=$BUNDLE2_COMPRESSIONS$
wire protocol command to wrong base URL
$ get-with-headers.py $LOCALIP:$HGPORT 'foo?cmd=capabilities' -
404 Not Found
content-length: 12
content-type: application/mercurial-0.1
date: * (glob)
server: * (glob)
0
Not Found
[1]
heads heads
$ get-with-headers.py $LOCALIP:$HGPORT '?cmd=heads' $ get-with-headers.py $LOCALIP:$HGPORT '?cmd=heads'
200 Script output follows 200 Script output follows
cad8025a2e87f88c06259790adfa15acb4080123 cad8025a2e87f88c06259790adfa15acb4080123
branches branches