This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2790

tests: additional test coverage of archive web command
ClosedPublic

Authored by indygreg on Mar 11 2018, 12:23 AM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHG40193f977a8b: tests: additional test coverage of archive web command
Summary

This command is special in a few ways. First, it is the only command
using the write() function from WSGI's start_response() function.
Second, it is setting a custom content-disposition header.

We change the test so it prints out full details of the HTTP
response. We also save the response body to a file so we can
verify its size and hash. The hash check will help ensure that
archive generation is deterministic.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Mar 11 2018, 12:23 AM
durin42 accepted this revision.Mar 12 2018, 5:10 PM
This revision is now accepted and ready to land.Mar 12 2018, 5:10 PM
Closed by commit rHG40193f977a8b: tests: additional test coverage of archive web command (authored by indygreg). · Explain WhyMar 12 2018, 5:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-archive.t (141 lines)

Diff 6926

tests/test-archive.t

> echo "allow$1 = True" >> .hg/hgrc > echo "allow$1 = True" >> .hg/hgrc
> test_archtype_run "$@" > test_archtype_run "$@"
> } > }
> test_archtype_run() { > test_archtype_run() {
> hg serve -p $HGPORT -d --pid-file=hg.pid -E errors.log \ > hg serve -p $HGPORT -d --pid-file=hg.pid -E errors.log \
> --config extensions.blackbox= --config blackbox.track=develwarn > --config extensions.blackbox= --config blackbox.track=develwarn
> cat hg.pid >> $DAEMON_PIDS > cat hg.pid >> $DAEMON_PIDS
> echo % $1 allowed should give 200 > echo % $1 allowed should give 200
> get-with-headers.py localhost:$HGPORT "archive/tip.$2" | head -n 1 > get-with-headers.py --bodyfile body localhost:$HGPORT "archive/tip.$2" -
> f --size --sha1 body
> echo % $3 and $4 disallowed should both give 403 > echo % $3 and $4 disallowed should both give 403
> get-with-headers.py localhost:$HGPORT "archive/tip.$3" | head -n 1 > get-with-headers.py --bodyfile body localhost:$HGPORT "archive/tip.$3" -
> get-with-headers.py localhost:$HGPORT "archive/tip.$4" | head -n 1 > f --size --sha1 body
> get-with-headers.py --bodyfile body localhost:$HGPORT "archive/tip.$4" -
> f --size --sha1 body
> killdaemons.py > killdaemons.py
> cat errors.log > cat errors.log
> hg blackbox --config extensions.blackbox= --config blackbox.track= > hg blackbox --config extensions.blackbox= --config blackbox.track=
> cp .hg/hgrc-base .hg/hgrc > cp .hg/hgrc-base .hg/hgrc
> } > }
check http return codes check http return codes
$ test_archtype gz tar.gz tar.bz2 zip $ test_archtype gz tar.gz tar.bz2 zip
% gz allowed should give 200 % gz allowed should give 200
200 Script output follows 200 Script output follows
content-disposition: attachment; filename=test-archive-1701ef1f1510.tar.gz
content-type: application/x-gzip
date: * (glob)
etag: W/"*" (glob)
server: * (glob)
transfer-encoding: chunked
body: size=408, sha1=8fa06531bddecc365a9f5edb0f88b65974bfe505
% tar.bz2 and zip disallowed should both give 403 % tar.bz2 and zip disallowed should both give 403
403 Archive type not allowed: bz2 403 Archive type not allowed: bz2
content-type: text/html; charset=ascii
date: * (glob)
etag: W/"*" (glob)
server: * (glob)
transfer-encoding: chunked
body: size=1451, sha1=4c5cf0f574446c44feb7f88f4e0e2a56bd92c352
403 Archive type not allowed: zip 403 Archive type not allowed: zip
content-type: text/html; charset=ascii
date: * (glob)
etag: W/"*" (glob)
server: * (glob)
transfer-encoding: chunked
body: size=1451, sha1=cbfa5574b337348bfd0564cc534474d002e7d6c7
$ test_archtype bz2 tar.bz2 zip tar.gz $ test_archtype bz2 tar.bz2 zip tar.gz
% bz2 allowed should give 200 % bz2 allowed should give 200
200 Script output follows 200 Script output follows
content-disposition: attachment; filename=test-archive-1701ef1f1510.tar.bz2
content-type: application/x-bzip2
date: * (glob)
etag: W/"*" (glob)
server: * (glob)
transfer-encoding: chunked
body: size=426, sha1=8d87f5aba6e14f1bfea6c232985982c278b2fb0b
% zip and tar.gz disallowed should both give 403 % zip and tar.gz disallowed should both give 403
403 Archive type not allowed: zip 403 Archive type not allowed: zip
content-type: text/html; charset=ascii
date: * (glob)
etag: W/"*" (glob)
server: * (glob)
transfer-encoding: chunked
body: size=1451, sha1=cbfa5574b337348bfd0564cc534474d002e7d6c7
403 Archive type not allowed: gz 403 Archive type not allowed: gz
content-type: text/html; charset=ascii
date: * (glob)
etag: W/"*" (glob)
server: * (glob)
transfer-encoding: chunked
body: size=1450, sha1=71f0b12d59f85fdcfe8ff493e2dc66863f2f7734
$ test_archtype zip zip tar.gz tar.bz2 $ test_archtype zip zip tar.gz tar.bz2
% zip allowed should give 200 % zip allowed should give 200
200 Script output follows 200 Script output follows
content-disposition: attachment; filename=test-archive-1701ef1f1510.zip
content-type: application/zip
date: * (glob)
etag: W/"*" (glob)
server: * (glob)
transfer-encoding: chunked
body: size=1377, sha1=677b14d3d048778d5eb5552c14a67e6192068650
% tar.gz and tar.bz2 disallowed should both give 403 % tar.gz and tar.bz2 disallowed should both give 403
403 Archive type not allowed: gz 403 Archive type not allowed: gz
content-type: text/html; charset=ascii
date: * (glob)
etag: W/"*" (glob)
server: * (glob)
transfer-encoding: chunked
body: size=1450, sha1=71f0b12d59f85fdcfe8ff493e2dc66863f2f7734
403 Archive type not allowed: bz2 403 Archive type not allowed: bz2
content-type: text/html; charset=ascii
date: * (glob)
etag: W/"*" (glob)
server: * (glob)
transfer-encoding: chunked
body: size=1451, sha1=4c5cf0f574446c44feb7f88f4e0e2a56bd92c352
check http return codes (with deprecated option) check http return codes (with deprecated option)
$ test_archtype_deprecated gz tar.gz tar.bz2 zip $ test_archtype_deprecated gz tar.gz tar.bz2 zip
% gz allowed should give 200 % gz allowed should give 200
200 Script output follows 200 Script output follows
content-disposition: attachment; filename=test-archive-1701ef1f1510.tar.gz
content-type: application/x-gzip
date: * (glob)
etag: W/"*" (glob)
server: * (glob)
transfer-encoding: chunked
body: size=408, sha1=8fa06531bddecc365a9f5edb0f88b65974bfe505
% tar.bz2 and zip disallowed should both give 403 % tar.bz2 and zip disallowed should both give 403
403 Archive type not allowed: bz2 403 Archive type not allowed: bz2
content-type: text/html; charset=ascii
date: * (glob)
etag: W/"*" (glob)
server: * (glob)
transfer-encoding: chunked
body: size=1451, sha1=4c5cf0f574446c44feb7f88f4e0e2a56bd92c352
403 Archive type not allowed: zip 403 Archive type not allowed: zip
content-type: text/html; charset=ascii
date: * (glob)
etag: W/"*" (glob)
server: * (glob)
transfer-encoding: chunked
body: size=1451, sha1=cbfa5574b337348bfd0564cc534474d002e7d6c7
$ test_archtype_deprecated bz2 tar.bz2 zip tar.gz $ test_archtype_deprecated bz2 tar.bz2 zip tar.gz
% bz2 allowed should give 200 % bz2 allowed should give 200
200 Script output follows 200 Script output follows
content-disposition: attachment; filename=test-archive-1701ef1f1510.tar.bz2
content-type: application/x-bzip2
date: * (glob)
etag: W/"*" (glob)
server: * (glob)
transfer-encoding: chunked
body: size=426, sha1=8d87f5aba6e14f1bfea6c232985982c278b2fb0b
% zip and tar.gz disallowed should both give 403 % zip and tar.gz disallowed should both give 403
403 Archive type not allowed: zip 403 Archive type not allowed: zip
content-type: text/html; charset=ascii
date: * (glob)
etag: W/"*" (glob)
server: * (glob)
transfer-encoding: chunked
body: size=1451, sha1=cbfa5574b337348bfd0564cc534474d002e7d6c7
403 Archive type not allowed: gz 403 Archive type not allowed: gz
content-type: text/html; charset=ascii
date: * (glob)
etag: W/"*" (glob)
server: * (glob)
transfer-encoding: chunked
body: size=1450, sha1=71f0b12d59f85fdcfe8ff493e2dc66863f2f7734
$ test_archtype_deprecated zip zip tar.gz tar.bz2 $ test_archtype_deprecated zip zip tar.gz tar.bz2
% zip allowed should give 200 % zip allowed should give 200
200 Script output follows 200 Script output follows
content-disposition: attachment; filename=test-archive-1701ef1f1510.zip
content-type: application/zip
date: * (glob)
etag: W/"*" (glob)
server: * (glob)
transfer-encoding: chunked
body: size=1377, sha1=677b14d3d048778d5eb5552c14a67e6192068650
% tar.gz and tar.bz2 disallowed should both give 403 % tar.gz and tar.bz2 disallowed should both give 403
403 Archive type not allowed: gz 403 Archive type not allowed: gz
content-type: text/html; charset=ascii
date: * (glob)
etag: W/"*" (glob)
server: * (glob)
transfer-encoding: chunked
body: size=1450, sha1=71f0b12d59f85fdcfe8ff493e2dc66863f2f7734
403 Archive type not allowed: bz2 403 Archive type not allowed: bz2
content-type: text/html; charset=ascii
date: * (glob)
etag: W/"*" (glob)
server: * (glob)
transfer-encoding: chunked
body: size=1451, sha1=4c5cf0f574446c44feb7f88f4e0e2a56bd92c352
$ echo "allow_archive = gz bz2 zip" >> .hg/hgrc $ echo "allow_archive = gz bz2 zip" >> .hg/hgrc
$ hg serve -p $HGPORT -d --pid-file=hg.pid -E errors.log $ hg serve -p $HGPORT -d --pid-file=hg.pid -E errors.log
$ cat hg.pid >> $DAEMON_PIDS $ cat hg.pid >> $DAEMON_PIDS
check archive links' order check archive links' order
$ get-with-headers.py localhost:$HGPORT "?revcount=1" | grep '/archive/tip.' $ get-with-headers.py localhost:$HGPORT "?revcount=1" | grep '/archive/tip.'