| durin42 |
| hg-reviewers |
It looks like the "sort" query string parameter was not being
honored properly.
| Lint Skipped |
| Unit Tests Skipped |
| Path | Packages | |||
|---|---|---|---|---|
| M | mercurial/hgweb/hgwebdir_mod.py (2 lines) |
| for row, parity in zip(rows, paritygen(self.stripecount)): | for row, parity in zip(rows, paritygen(self.stripecount)): | ||||
| row['parity'] = parity | row['parity'] = parity | ||||
| yield row | yield row | ||||
| self.refresh() | self.refresh() | ||||
| sortable = ["name", "description", "contact", "lastchange"] | sortable = ["name", "description", "contact", "lastchange"] | ||||
| sortcolumn, descending = sortdefault | sortcolumn, descending = sortdefault | ||||
| if 'sort' in wsgireq.req.qsparams: | if 'sort' in wsgireq.req.qsparams: | ||||
| sortcolum = wsgireq.req.qsparams['sort'] | sortcolumn = wsgireq.req.qsparams['sort'] | ||||
| descending = sortcolumn.startswith('-') | descending = sortcolumn.startswith('-') | ||||
| if descending: | if descending: | ||||
| sortcolumn = sortcolumn[1:] | sortcolumn = sortcolumn[1:] | ||||
| if sortcolumn not in sortable: | if sortcolumn not in sortable: | ||||
| sortcolumn = "" | sortcolumn = "" | ||||
| sort = [("sort_%s" % column, | sort = [("sort_%s" % column, | ||||
| "%s%s" % ((not descending and column == sortcolumn) | "%s%s" % ((not descending and column == sortcolumn) | ||||