This is an archive of the discontinued Mercurial Phabricator instance.

wireproto: mark SSHv2 as a version 1 transport
ClosedPublic

Authored by indygreg on Mar 30 2018, 5:16 PM.

Details

Summary

The version component is used for filtering/routing wire protocol
commands to their proper handler. The actual version 2 of the wire
protocol commands will use a different encoding of responses. We
already have tests using the version 2 SSH transport and version 2
of the wire protocol commands won't be implemented atomically.

This commit marks the SSHv2 transport as version 1 so it will
still invoke the version 1 commands. Once the commands are all
implemented in version 2, we can restore its proper behavior.

Some tests had to be disabled as a result of this change.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Mar 30 2018, 5:16 PM
durin42 accepted this revision.Apr 3 2018, 11:46 AM
This revision is now accepted and ready to land.Apr 3 2018, 11:46 AM
This revision was automatically updated to reflect the committed changes.