| mharbison72 |
| hg-reviewers |
I am reworking this code and moving to the current naming scheme help
readability.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| Path | Packages | |||
|---|---|---|---|---|
| M | mercurial/upgrade.py (16 lines) |
| Status | Author | Revision | |
|---|---|---|---|
| Closed | marmoute | ||
| Closed | marmoute | ||
| Closed | marmoute | ||
| Closed | marmoute | ||
| Closed | marmoute | ||
| Closed | marmoute | ||
| Closed | marmoute | ||
| Closed | marmoute | ||
| Closed | Alphare | ||
| Closed | Alphare | ||
| Closed | indygreg | ||
| Closed | mharbison72 | ||
| Closed | Alphare | ||
| Closed | marmoute | ||
| Closed | marmoute | ||
| Closed | marmoute | ||
| Closed | marmoute | ||
| Closed | SimonSapin | ||
| Closed | SimonSapin | ||
| Closed | SimonSapin | ||
| Closed | martinvonz |
| return supported | return supported | ||||
| def preservedrequirements(repo): | def preservedrequirements(repo): | ||||
| return set() | return set() | ||||
| DEFICIENCY = b'deficiency' | DEFICIENCY = b'deficiency' | ||||
| optimisation = b'optimization' | OPTIMISATION = b'optimization' | ||||
| class improvement(object): | class improvement(object): | ||||
| """Represents an improvement that can be made as part of an upgrade. | """Represents an improvement that can be made as part of an upgrade. | ||||
| The following attributes are defined on each instance: | The following attributes are defined on each instance: | ||||
| name | name | ||||
| Machine-readable string uniquely identifying this improvement. It | Machine-readable string uniquely identifying this improvement. It | ||||
| will be mapped to an action later in the upgrade process. | will be mapped to an action later in the upgrade process. | ||||
| type | type | ||||
| Either ``DEFICIENCY`` or ``optimisation``. A deficiency is an obvious | Either ``DEFICIENCY`` or ``OPTIMISATION``. A deficiency is an obvious | ||||
| problem. An optimization is an action (sometimes optional) that | problem. An optimization is an action (sometimes optional) that | ||||
| can be taken to further improve the state of the repository. | can be taken to further improve the state of the repository. | ||||
| description | description | ||||
| Message intended for humans explaining the improvement in more detail, | Message intended for humans explaining the improvement in more detail, | ||||
| including the implications of it. For ``DEFICIENCY`` types, should be | including the implications of it. For ``DEFICIENCY`` types, should be | ||||
| worded in the present tense. For ``optimisation`` types, should be | worded in the present tense. For ``OPTIMISATION`` types, should be | ||||
| worded in the future tense. | worded in the future tense. | ||||
| upgrademessage | upgrademessage | ||||
| Message intended for humans explaining what an upgrade addressing this | Message intended for humans explaining what an upgrade addressing this | ||||
| issue will do. Should be worded in the future tense. | issue will do. Should be worded in the future tense. | ||||
| """ | """ | ||||
| def __init__(self, name, type, description, upgrademessage): | def __init__(self, name, type, description, upgrademessage): | ||||
| """Determine optimisation that could be used during upgrade""" | """Determine optimisation that could be used during upgrade""" | ||||
| # These are unconditionally added. There is logic later that figures out | # These are unconditionally added. There is logic later that figures out | ||||
| # which ones to apply. | # which ones to apply. | ||||
| optimizations = [] | optimizations = [] | ||||
| optimizations.append( | optimizations.append( | ||||
| improvement( | improvement( | ||||
| name=b're-delta-parent', | name=b're-delta-parent', | ||||
| type=optimisation, | type=OPTIMISATION, | ||||
| description=_( | description=_( | ||||
| b'deltas within internal storage will be recalculated to ' | b'deltas within internal storage will be recalculated to ' | ||||
| b'choose an optimal base revision where this was not ' | b'choose an optimal base revision where this was not ' | ||||
| b'already done; the size of the repository may shrink and ' | b'already done; the size of the repository may shrink and ' | ||||
| b'various operations may become faster; the first time ' | b'various operations may become faster; the first time ' | ||||
| b'this optimization is performed could slow down upgrade ' | b'this optimization is performed could slow down upgrade ' | ||||
| b'execution considerably; subsequent invocations should ' | b'execution considerably; subsequent invocations should ' | ||||
| b'not run noticeably slower' | b'not run noticeably slower' | ||||
| ), | ), | ||||
| upgrademessage=_( | upgrademessage=_( | ||||
| b'deltas within internal storage will choose a new ' | b'deltas within internal storage will choose a new ' | ||||
| b'base revision if needed' | b'base revision if needed' | ||||
| ), | ), | ||||
| ) | ) | ||||
| ) | ) | ||||
| optimizations.append( | optimizations.append( | ||||
| improvement( | improvement( | ||||
| name=b're-delta-multibase', | name=b're-delta-multibase', | ||||
| type=optimisation, | type=OPTIMISATION, | ||||
| description=_( | description=_( | ||||
| b'deltas within internal storage will be recalculated ' | b'deltas within internal storage will be recalculated ' | ||||
| b'against multiple base revision and the smallest ' | b'against multiple base revision and the smallest ' | ||||
| b'difference will be used; the size of the repository may ' | b'difference will be used; the size of the repository may ' | ||||
| b'shrink significantly when there are many merges; this ' | b'shrink significantly when there are many merges; this ' | ||||
| b'optimization will slow down execution in proportion to ' | b'optimization will slow down execution in proportion to ' | ||||
| b'the number of merges in the repository and the amount ' | b'the number of merges in the repository and the amount ' | ||||
| b'of files in the repository; this slow down should not ' | b'of files in the repository; this slow down should not ' | ||||
| b'be significant unless there are tens of thousands of ' | b'be significant unless there are tens of thousands of ' | ||||
| b'files and thousands of merges' | b'files and thousands of merges' | ||||
| ), | ), | ||||
| upgrademessage=_( | upgrademessage=_( | ||||
| b'deltas within internal storage will choose an ' | b'deltas within internal storage will choose an ' | ||||
| b'optimal delta by computing deltas against multiple ' | b'optimal delta by computing deltas against multiple ' | ||||
| b'parents; may slow down execution time ' | b'parents; may slow down execution time ' | ||||
| b'significantly' | b'significantly' | ||||
| ), | ), | ||||
| ) | ) | ||||
| ) | ) | ||||
| optimizations.append( | optimizations.append( | ||||
| improvement( | improvement( | ||||
| name=b're-delta-all', | name=b're-delta-all', | ||||
| type=optimisation, | type=OPTIMISATION, | ||||
| description=_( | description=_( | ||||
| b'deltas within internal storage will always be ' | b'deltas within internal storage will always be ' | ||||
| b'recalculated without reusing prior deltas; this will ' | b'recalculated without reusing prior deltas; this will ' | ||||
| b'likely make execution run several times slower; this ' | b'likely make execution run several times slower; this ' | ||||
| b'optimization is typically not needed' | b'optimization is typically not needed' | ||||
| ), | ), | ||||
| upgrademessage=_( | upgrademessage=_( | ||||
| b'deltas within internal storage will be fully ' | b'deltas within internal storage will be fully ' | ||||
| b'recomputed; this will likely drastically slow down ' | b'recomputed; this will likely drastically slow down ' | ||||
| b'execution time' | b'execution time' | ||||
| ), | ), | ||||
| ) | ) | ||||
| ) | ) | ||||
| optimizations.append( | optimizations.append( | ||||
| improvement( | improvement( | ||||
| name=b're-delta-fulladd', | name=b're-delta-fulladd', | ||||
| type=optimisation, | type=OPTIMISATION, | ||||
| description=_( | description=_( | ||||
| b'every revision will be re-added as if it was new ' | b'every revision will be re-added as if it was new ' | ||||
| b'content. It will go through the full storage ' | b'content. It will go through the full storage ' | ||||
| b'mechanism giving extensions a chance to process it ' | b'mechanism giving extensions a chance to process it ' | ||||
| b'(eg. lfs). This is similar to "re-delta-all" but even ' | b'(eg. lfs). This is similar to "re-delta-all" but even ' | ||||
| b'slower since more logic is involved.' | b'slower since more logic is involved.' | ||||
| ), | ), | ||||
| upgrademessage=_( | upgrademessage=_( | ||||
| added = newreqs - repo.requirements | added = newreqs - repo.requirements | ||||
| if added: | if added: | ||||
| ui.write(_(b' added: ')) | ui.write(_(b' added: ')) | ||||
| write_labeled(added, "upgrade-repo.requirement.added") | write_labeled(added, "upgrade-repo.requirement.added") | ||||
| ui.write((b'\n')) | ui.write((b'\n')) | ||||
| ui.write(b'\n') | ui.write(b'\n') | ||||
| def printoptimisations(): | def printoptimisations(): | ||||
| optimisations = [a for a in actions if a.type == optimisation] | optimisations = [a for a in actions if a.type == OPTIMISATION] | ||||
| optimisations.sort(key=lambda a: a.name) | optimisations.sort(key=lambda a: a.name) | ||||
| if optimisations: | if optimisations: | ||||
| ui.write(_(b'optimisations: ')) | ui.write(_(b'optimisations: ')) | ||||
| write_labeled( | write_labeled( | ||||
| [a.name for a in optimisations], | [a.name for a in optimisations], | ||||
| "upgrade-repo.optimisation.performed", | "upgrade-repo.optimisation.performed", | ||||
| ) | ) | ||||
| ui.write(b'\n\n') | ui.write(b'\n\n') | ||||