Page MenuHomePhabricator

phabricator: allow local revisions to be specified with `phabupdate`
Needs ReviewPublic

Authored by mharbison72 on Sat, Nov 21, 12:22 AM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Summary

It's way easier and less error prone to specify a revset after importing a
series than to manually type in a series of Differentials.

Unlike most revision oriented commands, this requires the --rev option
explicitly because the existing DREVSPEC doesn't need to have the leading 'D',
and therefore the meaning is ambiguous. I wouldn't have a problem giving
precedence to the local revnum, but phabread and phabimport also use
DREVSPEC, and local revisions make no sense there. I would be fine with
modifying that definition to require the leading 'D', but I'm not sure how many
people are used to not specifying it.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

mharbison72 created this revision.Sat, Nov 21, 12:22 AM
Alphare accepted this revision.Mon, Nov 23, 10:33 AM
Alphare added a subscriber: Alphare.

This seems like the right choice to me, confusing the local and remote revisions would be bad.

This seems like the right choice to me, confusing the local and remote revisions would be bad.

Which one, because we could disallow differential revs without the leading 'D', and not be ambiguous. I kind of lean towards that the more I think about it, but I haven't considered how easy it would be to detect when there's a mini revset language to account for.