This is an archive of the discontinued Mercurial Phabricator instance.

Differential D9484

upgrade: drop an outdated comment
ClosedPublic

Authored by marmoute on Dec 1 2020, 5:12 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGad9dd4d333be: upgrade: drop an outdated comment
Summary

We can control the added/removed requirement through config for multiple years.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Dec 1 2020, 5:12 PM
baymax updated this revision to Diff 24035.Dec 4 2020, 6:48 PM
pulkit accepted this revision.Dec 6 2020, 6:09 AM
This revision is now accepted and ready to land.Dec 6 2020, 6:09 AM
marmoute added a commit: rHGad9dd4d333be: upgrade: drop an outdated comment.Dec 6 2020, 7:15 AM
Closed by commit rHGad9dd4d333be: upgrade: drop an outdated comment (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/upgrade.py (2 lines)

Diff 24060

mercurial/upgrade.py

else: else:
# none are enabled # none are enabled
for upgrade, __ in specified: for upgrade, __ in specified:
revlogs.discard(upgrade) revlogs.discard(upgrade)
# Ensure the repository can be upgraded. # Ensure the repository can be upgraded.
upgrade_actions.check_source_requirements(repo) upgrade_actions.check_source_requirements(repo)
# FUTURE there is potentially a need to control the wanted requirements via
# command arguments or via an extension hook point.
newreqs = localrepo.newreporequirements( newreqs = localrepo.newreporequirements(
repo.ui, localrepo.defaultcreateopts(repo.ui) repo.ui, localrepo.defaultcreateopts(repo.ui)
) )
newreqs.update(upgrade_actions.preservedrequirements(repo)) newreqs.update(upgrade_actions.preservedrequirements(repo))
noremovereqs = ( noremovereqs = (
repo.requirements repo.requirements
- newreqs - newreqs