Page MenuHomePhabricator

upgrade: display the list of processed revlog before proceeding
ClosedPublic

Authored by marmoute on Nov 30 2020, 10:43 AM.

Details

Summary

This help to make sure we don't wrongly skip some in the test and to make sure
the user is aware of the amount of processing they is signing up for.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Nov 30 2020, 10:43 AM

This looks good other than the one question I had.

mercurial/upgrade.py
1344–1349

Were these meant to be _(), or is this trying to foil test-check-something.t that looks for non i18n messages?

pulkit requested changes to this revision.Dec 2 2020, 2:11 AM
pulkit added a subscriber: pulkit.
pulkit added inline comments.
mercurial/upgrade.py
1344–1349

Should be _() I think.

This revision now requires changes to proceed.Dec 2 2020, 2:11 AM
pulkit added inline comments.Dec 2 2020, 1:10 PM
mercurial/upgrade.py
1344–1349

@marmoute this is still not done.

marmoute added inline comments.Dec 2 2020, 1:18 PM
mercurial/upgrade.py
1344–1349

This is a debug command, so it does not needs i18n. Multiple output around that is not using i18n either.

mharbison72 added inline comments.Dec 2 2020, 2:03 PM
mercurial/upgrade.py
1344–1349

This is a debug command, so it does not needs i18n. Multiple output around that is not using i18n either.

Right, but e.g. ui.status() immediately above this doesn't wrap it in parentheses either, which was my source of confusion.

pulkit added inline comments.Dec 2 2020, 2:40 PM
mercurial/upgrade.py
1344–1349

Yes, the extra parentheses confuses and implies that _ is missing.

marmoute added inline comments.Dec 4 2020, 10:54 AM
mercurial/upgrade.py
1344–1349

I don't know why check code complained about one, but not the other :-/

pulkit accepted this revision.Dec 4 2020, 1:36 PM
This revision is now accepted and ready to land.Dec 4 2020, 1:36 PM