This help to make sure we don't wrongly skip some in the test and to make sure
the user is aware of the amount of processing they is signing up for.
Details
- Reviewers
pulkit - Group Reviewers
hg-reviewers - Commits
- rHG6c960b708ac4: upgrade: display the list of processed revlog before proceeding
Diff Detail
- Repository
- rHG Mercurial
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
This looks good other than the one question I had.
mercurial/upgrade.py | ||
---|---|---|
1344–1349 | Were these meant to be _(), or is this trying to foil test-check-something.t that looks for non i18n messages? |
mercurial/upgrade.py | ||
---|---|---|
1344–1349 | Should be _() I think. |
mercurial/upgrade.py | ||
---|---|---|
1344–1349 | This is a debug command, so it does not needs i18n. Multiple output around that is not using i18n either. |
mercurial/upgrade.py | ||
---|---|---|
1344–1349 |
Right, but e.g. ui.status() immediately above this doesn't wrap it in parentheses either, which was my source of confusion. |
mercurial/upgrade.py | ||
---|---|---|
1344–1349 | Yes, the extra parentheses confuses and implies that _ is missing. |
mercurial/upgrade.py | ||
---|---|---|
1344–1349 | I don't know why check code complained about one, but not the other :-/ |
Were these meant to be _(), or is this trying to foil test-check-something.t that looks for non i18n messages?