Page MenuHomePhabricator

upgrade: start moving the "to be happening" data in a dedicated object
ClosedPublic

Authored by marmoute on Dec 1 2020, 5:12 PM.

Details

Summary

The upgrade code has a lot of logic to determine which action needs to be
performed depending of various element (sometimes depending from each other). It
would be nice to have a consistent object representing this. That could be
cleanly passed and avoid some logic duplication.

So we create this object as a start.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Dec 1 2020, 5:12 PM
baymax updated this revision to Diff 24038.Dec 4 2020, 6:48 PM
pulkit requested changes to this revision.Dec 6 2020, 6:27 AM
pulkit added a subscriber: pulkit.
pulkit added inline comments.
mercurial/upgrade.py
184

Seems like incomplete statement.

This revision now requires changes to proceed.Dec 6 2020, 6:27 AM
baymax updated this revision to Diff 24071.Dec 6 2020, 10:09 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

pulkit accepted this revision.Dec 7 2020, 3:48 AM
This revision is now accepted and ready to land.Dec 7 2020, 3:48 AM