This is an archive of the discontinued Mercurial Phabricator instance.

revlog: simplify a conditionnal in _enforceinlinesize
ClosedPublic

Authored by marmoute on May 3 2021, 7:50 AM.

Details

Summary

This is a gratuitous change to make things a bit easier to read.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.May 3 2021, 7:50 AM

This adds a penalty for the non-inline case?

Since the index is already in memory, I don't expect the computation to come at noticeable cost.

baymax updated this revision to Diff 27508.May 3 2021, 9:44 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Alphare accepted this revision.May 11 2021, 10:03 AM
Alphare added a subscriber: Alphare.

I agree with @marmoute on this one, this should be negligible.

This revision is now accepted and ready to land.May 11 2021, 10:03 AM
This revision was automatically updated to reflect the committed changes.