This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1074

branch: add a --rev flag to change branch name of given revisions
ClosedPublic

Authored by pulkit on Oct 14 2017, 10:41 AM.

Details

Reviewers
dlax
ryanmce
lothiraldan
durin42
Group Reviewers
hg-reviewers
Commits
rHG3bd8ab4c80a5: branch: add a --rev flag to change branch name of given revisions
Summary

This patch adds a new --rev flag to hg branch which can be used to change branch
of revisions. This is motivated from topic extension where you can change topic
on revisions but this one has few restrictions which are:

  1. You cannot change branch name in between the stack
  2. You cannot change branch name and set it to an existing name
  3. You cannot change branch of non-linear set of commits
  4. You cannot change branch of merge commits.

Tests are added for the same.

.. feature::

An experimental flag `--rev` to `hg branch` which can be used to change
branch of changesets.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Oct 14 2017, 10:41 AM
dlax added a subscriber: dlax.Oct 15 2017, 5:02 AM
dlax added inline comments.
mercurial/cmdutil.py
731

typo: betwen

Also, I'm not sure "between" is appropriate here. Maybe "cannot change branch in the middle of a stack"?

752

nit: with % on the continuation line and alignment with opening parenthesis, it'd be more readable.

pulkit updated this revision to Diff 2789.Oct 15 2017, 1:56 PM
dlax requested changes to this revision.Oct 16 2017, 3:57 AM

This looks correct to me overall.
I use this feature with topics a lot and find it pretty convenient so I guess it might make sense for named branches in some workflows.

mercurial/cmdutil.py
752

This message is not tested, maybe add a --debug call to one of the tests?

774

That comment isn't really helpful as is. Maybe explain how you handle phase instead?

782

Isn't rewrote == len(replacements)?

mercurial/commands.py
997

Nit: could you move the closing ] on the next line and add a , at the end of the new line? This way next time we add an option, there will be only a one-line + diff.

1036

Maybe _().

tests/test-branch-change.t
42

Not sure why, but many titles' underlines are either too long or too short. Could you make these consistent?

68

"in the middle of the stack"

256

typo: mutliple

This revision now requires changes to proceed.Oct 16 2017, 3:57 AM
pulkit updated this revision to Diff 2807.Oct 16 2017, 8:30 AM
pulkit marked 9 inline comments as done.Oct 16 2017, 8:31 AM
dlax accepted this revision.Oct 16 2017, 8:36 AM
ryanmce requested changes to this revision.Oct 17 2017, 8:53 AM
ryanmce added a subscriber: ryanmce.
ryanmce added inline comments.
mercurial/cmdutil.py
722–731

What about an unclean working copy? It looks like that's supported -- could we make sure it's tested?

733–734

In theory, the phase boundary could move after our check but before we take the repolock. Can we guard against that please?

Two ways to accomplish this:

1/ Take the repo lock earlier
2/ Check before repo lock (fast path) and again after the repo lock is held (in case something changed)

791–792

Seems like we need a refactor? (out of scope for this change though)

tests/test-branch-change.t
8

nit: I'd prefer no newline in the glog output so things are more compact

10

This test needs to include a case where we strip commits, especially with a merge, just so the behavior is clear in this change.

That will probably (in my understanding of the current code) expose an issue that needs to be fixed.

17–34

Not sure we need this many commits for the test to be useful.

304–305

Hm, I think I'd prefer this to be an error about public changesets rather than a no-op with a 0 return value. Trying to modify the branch of public changesets -- even if the change is a no-op, still seems like an error to me. Thoughts?

This revision now requires changes to proceed.Oct 17 2017, 8:53 AM
pulkit added inline comments.Oct 17 2017, 9:26 AM
mercurial/cmdutil.py
791–792

Yeah, I will be happy to do that in next cycle. Can you suggest a name for file in which we can split cmdutil.py.

tests/test-branch-change.t
304–305

Oh, no. They are not public changesets. The test for public changeset is just above it. I will plug the phase info in the glog output in next version.

pulkit edited the summary of this revision. (Show Details)Oct 17 2017, 4:52 PM
pulkit updated this revision to Diff 2944.
pulkit marked 4 inline comments as done.Oct 17 2017, 5:01 PM
pulkit added inline comments.
mercurial/cmdutil.py
722–731

It's not supported. Handled that case and added a test. Thanks!

733–734

Improved the implementation by taking lock earlier. Thanks!

tests/test-branch-change.t
10

Oh, I didn't know that. Just banned merge revisions for now.

pulkit added a comment.Nov 2 2017, 2:14 PM

Re-requesting review since the freeze is over.

lothiraldan added a subscriber: lothiraldan.Nov 17 2017, 5:38 AM

Looking good, should we allow changing the branch if any changeset is unstable or obsolete?

mercurial/cmdutil.py
723

Small typo, missing space between in and case

774

For safety, I would add a check that p1 and p2 are not obsolete here.

pulkit added a comment.Nov 28 2017, 5:49 PM
In D1074#23972, @lothiraldan wrote:

Looking good, should we allow changing the branch if any changeset is unstable or obsolete?

For unstable yes, for obsolete no. Will add a check and test for obsolete case.

mercurial/cmdutil.py
774

A user may want to change branch of an unstable changeset which I think is okay. I am not sure why you want that check?

pulkit updated this revision to Diff 4082.Dec 2 2017, 1:26 PM
pulkit added a comment.Dec 4 2017, 9:38 AM

This was send before the code freeze of last major release but since it was late in the release, it was not taken. Let's iterate on it now.

pulkit added subscribers: indygreg, yuja, krbullock, durin42.Jan 15 2018, 1:45 PM

@durin42 @yuja @indygreg @krbullock this one is lying here for months. Does this conflict with anything or is a BC or something else, or was just missed for the review?

lothiraldan added a comment.Jan 16 2018, 3:56 AM

Apart from my review, it looks good to me.

Also I don't think you have a test when trying to change the branch of several changesets on different branches. If not, could you add one?

mercurial/cmdutil.py
734

Might be helpful to precise which changeset is a merge commit.

736

Might be helpful to precise which changeset is am obsolete commit.

tests/test-branch-change.t
144

You should update the revset to use the same as the next glog call (.^)::

martinvonz added a subscriber: martinvonz.Jan 18 2018, 2:26 PM
martinvonz added inline comments.
mercurial/cmdutil.py
723

"in case of uncommited merge or dirty wdir"? (note that there are 4 fixes there)

725

may want to check if revs is empty (e.g. hg branch -r 'draft() - all()' foo)

731

maybe if not root.mutable():

740–744

children() can be expensive because it iterates over all later revisions (in revlog order). So when you want to call children() for many revisions (especially old revisions), it can be better to do a single scan. This *might* be better:

if repo.revs('(%ld::head()) - %ld', heads, heads):
  raise error.Abort(_("cannot change branch in middle of a stack"))

I'm not sure it will be, or if it's even correct, so please test (or just tell me that this command will be used rarely enough that no one cares).

mercurial/commands.py
1046–1051

Does this need to be modified to work with --rev? I've never used hg branch, but it sounds like hg branch foo (without --force) is supposed to fail if foo is already taken unless one of the working directory parents already has that name. Should we do the corresponding check for --rev? If not, it seems like we should at least *not* do the check (in its current form) when --rev is given. If I'm doing hg branch --rev deadbeef foo, it doesn't seem relevant what the branch names in my working directory parents are. Would be good to add a test case or two for this too.

pulkit updated this revision to Diff 4934.Jan 19 2018, 2:44 AM
pulkit marked 5 inline comments as done.Jan 19 2018, 2:57 AM
pulkit removed subscribers: durin42, krbullock, yuja, indygreg.
pulkit added inline comments.
mercurial/commands.py
1046–1051

This is a very basic and experimental implementation, hence I have changed the logic to not accept a new name if any such name already exists. Test cases are also added.

lothiraldan accepted this revision.Jan 19 2018, 3:32 AM
pulkit added inline comments.Jan 19 2018, 9:31 AM
mercurial/cmdutil.py
742

After some more testing, I found this is not correct and raise the error even in cases when it should not. For example:

o 3

o 2
/

o 1
o 0

Here if I want to change the branch of 1::2, this will raise error however this should be completely fine if we have allowunstable enabled. So in next version, I am going to add a test for allowunstable and if that's enabled, allow to change branch of 1::2.

durin42 accepted this revision.Jan 19 2018, 2:54 PM
durin42 added a comment.Jan 19 2018, 2:56 PM

Accepting this since it seems generally liked and is marked experimental. We can always rip it out if it turns out to be a mistake.

Closed by commit rHG3bd8ab4c80a5: branch: add a --rev flag to change branch name of given revisions (authored by pulkit). · Explain WhyJan 19 2018, 3:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/cmdutil.py (80 lines)
Mmercurial/commands.py (10 lines)
AMtests/test-branch-change.t (324 lines)
Mtests/test-completion.t (2 lines)

Diff 2807

mercurial/cmdutil.py

encoding, encoding,
error, error,
formatter, formatter,
graphmod, graphmod,
match as matchmod, match as matchmod,
obsolete, obsolete,
patch, patch,
pathutil, pathutil,
phases,
pycompat, pycompat,
registrar, registrar,
revlog, revlog,
revset, revset,
scmutil, scmutil,
smartset, smartset,
templatekw, templatekw,
templater, templater,
clist = sorted(choice) clist = sorted(choice)
raise error.AmbiguousCommand(cmd, clist) raise error.AmbiguousCommand(cmd, clist)
if choice: if choice:
return list(choice.values())[0] return list(choice.values())[0]
raise error.UnknownCommand(cmd, allcmds) raise error.UnknownCommand(cmd, allcmds)
def changebranch(ui, repo, revs, label):
""" Change the branch name of given revs to label """
revs = scmutil.revrange(repo, revs)
roots = repo.revs('roots(%ld)', revs)
lothiraldanUnsubmitted
Not Done

Small typo, missing space between in and case

lothiraldan: Small typo, missing space between `in` and `case`
martinvonzUnsubmitted
Done

"in case of uncommited merge or dirty wdir"? (note that there are 4 fixes there)

martinvonz: "in case of uncommited merge or dirty wdir"? (note that there are 4 fixes there)
if len(roots) > 1:
raise error.Abort(_("cannot change branch of non-linear revisions"))
martinvonzUnsubmitted
Done

may want to check if revs is empty (e.g. hg branch -r 'draft() - all()' foo)

martinvonz: may want to check if revs is empty (e.g. `hg branch -r 'draft() - all()' foo`)
root = repo[roots.first()]
if root.phase() <= phases.public:
raise error.Abort(_("cannot change branch of public revisions"))
heads = repo.revs('head() and %ld', revs)
if len(heads) < 1:
raise error.Abort(_("cannot change branch in middle of a stack"))
dlaxUnsubmitted
Done

typo: betwen

Also, I'm not sure "between" is appropriate here. Maybe "cannot change branch in the middle of a stack"?

dlax: typo: betwen Also, I'm not sure "between" is appropriate here. Maybe "cannot change branch in…
ryanmceUnsubmitted
Not Done

What about an unclean working copy? It looks like that's supported -- could we make sure it's tested?

ryanmce: What about an unclean working copy? It looks like that's supported -- could we make sure it's…
pulkitAuthorUnsubmitted
Not Done

It's not supported. Handled that case and added a test. Thanks!

pulkit: It's not supported. Handled that case and added a test. Thanks!
martinvonzUnsubmitted
Done

maybe if not root.mutable():

martinvonz: maybe `if not root.mutable():`
replacements = {}
with repo.wlock(), repo.lock(), repo.transaction('branches'):
ryanmceUnsubmitted
Not Done

In theory, the phase boundary could move after our check but before we take the repolock. Can we guard against that please?

Two ways to accomplish this:

1/ Take the repo lock earlier
2/ Check before repo lock (fast path) and again after the repo lock is held (in case something changed)

ryanmce: In theory, the phase boundary could move after our check but before we take the repolock. Can…
pulkitAuthorUnsubmitted
Not Done

Improved the implementation by taking lock earlier. Thanks!

pulkit: Improved the implementation by taking lock earlier. Thanks!
lothiraldanUnsubmitted
Not Done

Might be helpful to precise which changeset is a merge commit.

lothiraldan: Might be helpful to precise which changeset is a merge commit.
# avoid import cycle mercurial.cmdutil -> mercurial.context ->
# mercurial.subrepo -> mercurial.cmdutil
lothiraldanUnsubmitted
Not Done

Might be helpful to precise which changeset is am obsolete commit.

lothiraldan: Might be helpful to precise which changeset is am obsolete commit.
from . import context
for rev in revs:
ctx = repo[rev]
oldbranch = ctx.branch()
# check if ctx has same branch
if oldbranch == label:
pulkitAuthorUnsubmitted
Not Done

After some more testing, I found this is not correct and raise the error even in cases when it should not. For example:

o 3

o 2
/

o 1
o 0

Here if I want to change the branch of 1::2, this will raise error however this should be completely fine if we have allowunstable enabled. So in next version, I am going to add a test for allowunstable and if that's enabled, allow to change branch of 1::2.

pulkit: After some more testing, I found this is not correct and raise the error even in cases when it…
continue
martinvonzUnsubmitted
Done

children() can be expensive because it iterates over all later revisions (in revlog order). So when you want to call children() for many revisions (especially old revisions), it can be better to do a single scan. This *might* be better:

if repo.revs('(%ld::head()) - %ld', heads, heads):
  raise error.Abort(_("cannot change branch in middle of a stack"))

I'm not sure it will be, or if it's even correct, so please test (or just tell me that this command will be used rarely enough that no one cares).

martinvonz: children() can be expensive because it iterates over all later revisions (in revlog order). So…
def filectxfn(repo, newctx, path):
try:
return ctx[path]
except error.ManifestLookupError:
return None
ui.debug("changing branch of '%s' from '%s' to '%s'\n"
% (hex(ctx.node()), oldbranch, label))
dlaxUnsubmitted
Done

nit: with % on the continuation line and alignment with opening parenthesis, it'd be more readable.

dlax: nit: with `%` on the continuation line and alignment with opening parenthesis, it'd be more…
dlaxUnsubmitted
Done

This message is not tested, maybe add a --debug call to one of the tests?

dlax: This message is not tested, maybe add a `--debug` call to one of the tests?
extra = ctx.extra()
extra['branch_change'] = hex(ctx.node())
# While changing branch of set of linear commits, make sure that
# we base our commits on new parent rather than old parent which
# was obsoleted while changing the branch
p1 = ctx.p1().node()
p2 = ctx.p2().node()
if p1 in replacements:
p1 = replacements[p1][0]
if p2 in replacements:
p2 = replacements[p2][0]
mc = context.memctx(repo, (p1, p2),
ctx.description(),
ctx.files(),
filectxfn,
user=ctx.user(),
date=ctx.date(),
extra=extra,
branch=label)
commitphase = ctx.phase()
dlaxUnsubmitted
Not Done

That comment isn't really helpful as is. Maybe explain how you handle phase instead?

dlax: That comment isn't really helpful as is. Maybe explain how you handle phase instead?
lothiraldanUnsubmitted
Not Done

For safety, I would add a check that p1 and p2 are not obsolete here.

lothiraldan: For safety, I would add a check that p1 and p2 are not obsolete here.
pulkitAuthorUnsubmitted
Not Done

A user may want to change branch of an unstable changeset which I think is okay. I am not sure why you want that check?

pulkit: A user may want to change branch of an unstable changeset which I think is okay. I am not sure…
overrides = {('phases', 'new-commit'): commitphase}
with repo.ui.configoverride(overrides, 'branch-change'):
newnode = repo.commitctx(mc)
replacements[ctx.node()] = (newnode,)
ui.debug('new node id is %s\n' % hex(newnode))
# create obsmarkers and move bookmarks
dlaxUnsubmitted
Done

Isn't rewrote == len(replacements)?

dlax: Isn't `rewrote == len(replacements)`?
scmutil.cleanupnodes(repo, replacements, 'branch-change')
# move the working copy too
wctx = repo[None]
# in-progress merge is a bit too complex for now.
if len(wctx.parents()) == 1:
newid = replacements.get(wctx.p1().node())
if newid is not None:
# avoid import cycle mercurial.cmdutil -> mercurial.hg ->
# mercurial.cmdutil
ryanmceUnsubmitted
Not Done

Seems like we need a refactor? (out of scope for this change though)

ryanmce: Seems like we need a refactor? (out of scope for this change though)
pulkitAuthorUnsubmitted
Not Done

Yeah, I will be happy to do that in next cycle. Can you suggest a name for file in which we can split cmdutil.py.

pulkit: Yeah, I will be happy to do that in next cycle. Can you suggest a name for file in which we can…
from . import hg
hg.update(repo, newid[0], quietempty=True)
ui.status(_("changed branch on %d changesets\n") % len(replacements))
def findrepo(p): def findrepo(p):
while not os.path.isdir(os.path.join(p, ".hg")): while not os.path.isdir(os.path.join(p, ".hg")):
oldp, p = p, os.path.dirname(p) oldp, p = p, os.path.dirname(p)
if p == oldp: if p == oldp:
return None return None
return p return p

mercurial/commands.py

else: else:
bookmarks.deactivate(repo) bookmarks.deactivate(repo)
else: # show bookmarks else: # show bookmarks
bookmarks.printbookmarks(ui, repo, **opts) bookmarks.printbookmarks(ui, repo, **opts)
@command('branch', @command('branch',
[('f', 'force', None, [('f', 'force', None,
_('set branch name even if it shadows an existing branch')), _('set branch name even if it shadows an existing branch')),
('C', 'clean', None, _('reset branch name to parent branch name'))], ('C', 'clean', None, _('reset branch name to parent branch name')),
('r', 'rev', [], _('change branches of the given revs (EXPERIMENTAL)')),
dlaxUnsubmitted
Done

Nit: could you move the closing ] on the next line and add a , at the end of the new line? This way next time we add an option, there will be only a one-line + diff.

dlax: Nit: could you move the closing `]` on the next line and add a `,` at the end of the new line?
],
_('[-fC] [NAME]')) _('[-fC] [NAME]'))
def branch(ui, repo, label=None, **opts): def branch(ui, repo, label=None, **opts):
"""set or show the current branch name """set or show the current branch name
.. note:: .. note::
Branch names are permanent and global. Use :hg:`bookmark` to create a Branch names are permanent and global. Use :hg:`bookmark` to create a
light-weight bookmark instead. See :hg:`help glossary` for more light-weight bookmark instead. See :hg:`help glossary` for more
Use the command :hg:`update` to switch to an existing branch. Use Use the command :hg:`update` to switch to an existing branch. Use
:hg:`commit --close-branch` to mark this branch head as closed. :hg:`commit --close-branch` to mark this branch head as closed.
When all heads of a branch are closed, the branch will be When all heads of a branch are closed, the branch will be
considered closed. considered closed.
Returns 0 on success. Returns 0 on success.
""" """
opts = pycompat.byteskwargs(opts) opts = pycompat.byteskwargs(opts)
revs = opts.get('rev')
if label: if label:
label = label.strip() label = label.strip()
if not opts.get('clean') and not label: if not opts.get('clean') and not label:
if revs:
raise error.Abort(_("no branch name specified for the revisions"))
dlaxUnsubmitted
Done

Maybe _().

dlax: Maybe `_()`.
ui.write("%s\n" % repo.dirstate.branch()) ui.write("%s\n" % repo.dirstate.branch())
return return
with repo.wlock(): with repo.wlock():
if opts.get('clean'): if opts.get('clean'):
label = repo[None].p1().branch() label = repo[None].p1().branch()
repo.dirstate.setbranch(label) repo.dirstate.setbranch(label)
ui.status(_('reset working directory to branch %s\n') % label) ui.status(_('reset working directory to branch %s\n') % label)
elif label: elif label:
if not opts.get('force') and label in repo.branchmap(): if not opts.get('force') and label in repo.branchmap():
if label not in [p.branch() for p in repo[None].parents()]: if label not in [p.branch() for p in repo[None].parents()]:
raise error.Abort(_('a branch of the same name already' raise error.Abort(_('a branch of the same name already'
' exists'), ' exists'),
# i18n: "it" refers to an existing branch # i18n: "it" refers to an existing branch
hint=_("use 'hg update' to switch to it")) hint=_("use 'hg update' to switch to it"))
martinvonzUnsubmitted
Not Done

Does this need to be modified to work with --rev? I've never used hg branch, but it sounds like hg branch foo (without --force) is supposed to fail if foo is already taken unless one of the working directory parents already has that name. Should we do the corresponding check for --rev? If not, it seems like we should at least *not* do the check (in its current form) when --rev is given. If I'm doing hg branch --rev deadbeef foo, it doesn't seem relevant what the branch names in my working directory parents are. Would be good to add a test case or two for this too.

martinvonz: Does this need to be modified to work with --rev? I've never used `hg branch`, but it sounds…
pulkitAuthorUnsubmitted
Not Done

This is a very basic and experimental implementation, hence I have changed the logic to not accept a new name if any such name already exists. Test cases are also added.

pulkit: This is a very basic and experimental implementation, hence I have changed the logic to not…
scmutil.checknewlabel(repo, label, 'branch') scmutil.checknewlabel(repo, label, 'branch')
if revs:
return cmdutil.changebranch(ui, repo, revs, label)
repo.dirstate.setbranch(label) repo.dirstate.setbranch(label)
ui.status(_('marked working directory as branch %s\n') % label) ui.status(_('marked working directory as branch %s\n') % label)
# find any open named branches aside from default # find any open named branches aside from default
others = [n for n, h, t, c in repo.branchmap().iterbranches() others = [n for n, h, t, c in repo.branchmap().iterbranches()
if n != "default" and not c] if n != "default" and not c]
if not others: if not others:
ui.status(_('(branches are permanent and global, ' ui.status(_('(branches are permanent and global, '

tests/test-branch-change.t

  • This file was added.
Testing changing branch on commits
==================================
Setup
$ cat >> $HGRCPATH << EOF
> [alias]
> glog = log -G -T "{rev}:{node|short} {desc}\n{branch} ({bookmarks})"
ryanmceUnsubmitted
Not Done

nit: I'd prefer no newline in the glog output so things are more compact

ryanmce: nit: I'd prefer no newline in the glog output so things are more compact
> [experimental]
> evolution = createmarkers
ryanmceUnsubmitted
Not Done

This test needs to include a case where we strip commits, especially with a merge, just so the behavior is clear in this change.

That will probably (in my understanding of the current code) expose an issue that needs to be fixed.

ryanmce: This test needs to include a case where we strip commits, especially with a merge, just so the…
pulkitAuthorUnsubmitted
Not Done

Oh, I didn't know that. Just banned merge revisions for now.

pulkit: Oh, I didn't know that. Just banned merge revisions for now.
> [extensions]
> rebase=
> EOF
$ hg init repo
$ cd repo
$ for ch in a b c d e f g h; do echo foo >> $ch; hg ci -Aqm "Added "$ch; done
$ hg glog
@ 7:ec2426147f0e Added h
| default ()
o 6:87d6d6676308 Added g
| default ()
o 5:825660c69f0c Added f
| default ()
o 4:aa98ab95a928 Added e
| default ()
o 3:62615734edd5 Added d
| default ()
o 2:28ad74487de9 Added c
| default ()
o 1:29becc82797a Added b
| default ()
o 0:18d04c59bb5d Added a
default ()
ryanmceUnsubmitted
Done

Not sure we need this many commits for the test to be useful.

ryanmce: Not sure we need this many commits for the test to be useful.
$ hg branches
default 7:ec2426147f0e
Try without passing a new branch name
$ hg branch -r 5::7
abort: no branch name specified for the revisions
dlaxUnsubmitted
Done

Not sure why, but many titles' underlines are either too long or too short. Could you make these consistent?

dlax: Not sure why, but many titles' underlines are either too long or too short. Could you make…
[255]
Setting an invalid branch name
$ hg branch -r 5::7 a:b
abort: ':' cannot be used in a name
[255]
$ hg branch -r 5::7 tip
abort: the name 'tip' is reserved
[255]
$ hg branch -r 5::7 1234
abort: cannot use an integer as a name
[255]
Change on non-linear set of commits
$ hg branch -r 4 -r 6 foo
abort: cannot change branch of non-linear revisions
[255]
Change in middle of the stack (linear commits)
$ hg branch -r 4::6 foo
abort: cannot change branch in middle of a stack
[255]
dlaxUnsubmitted
Done

"in the middle of the stack"

dlax: "in the middle of the stack"
Changing branch on linear set of commits from head
Without obsmarkers
$ hg branch -r 5::7 foo --config experimental.evolution=!
changed branch on 3 changesets
saved backup bundle to $TESTTMP/repo/.hg/strip-backup/825660c69f0c-ce9f7a94-branch-change.hg (glob)
$ hg glog
@ 7:c23036697d1b Added h
| foo ()
o 6:a53c3f56770a Added g
| foo ()
o 5:ff1da3b38f9e Added f
| foo ()
o 4:aa98ab95a928 Added e
| default ()
o 3:62615734edd5 Added d
| default ()
o 2:28ad74487de9 Added c
| default ()
o 1:29becc82797a Added b
| default ()
o 0:18d04c59bb5d Added a
default ()
$ hg branches
foo 7:c23036697d1b
default 4:aa98ab95a928 (inactive)
With obsmarkers
$ hg branch -r 5::7 bar
changed branch on 3 changesets
$ hg glog
@ 10:e6dd2bf0e93e Added h
| bar ()
o 9:b71d0e6b76ec Added g
| bar ()
o 8:e47e2354372c Added f
| bar ()
o 4:aa98ab95a928 Added e
| default ()
o 3:62615734edd5 Added d
| default ()
o 2:28ad74487de9 Added c
| default ()
o 1:29becc82797a Added b
| default ()
o 0:18d04c59bb5d Added a
default ()
$ hg branches
bar 10:e6dd2bf0e93e
default 4:aa98ab95a928 (inactive)
Change branch name to an existing branch
$ hg branch -r . default
abort: a branch of the same name already exists
(use 'hg update' to switch to it)
[255]
Make sure bookmark movement is correct
$ hg bookmark b1
$ hg glog -r .
@ 10:e6dd2bf0e93e Added h
| bar (b1)
~
$ hg branch -r '(.^)::' foo --debug
changing branch of 'b71d0e6b76ecd9179149fd19962019ea505c099c' from 'bar' to 'foo'
committing files:
g
committing manifest
committing changelog
lothiraldanUnsubmitted
Done

You should update the revset to use the same as the next glog call (.^)::

lothiraldan: You should update the revset to use the same as the next glog call `(.^)::`
new node id is 6bcbfdc170f74a3647b3afa24fdba997883750df
changing branch of 'e6dd2bf0e93e140e9b185d8df7d2fd55b01c270a' from 'bar' to 'foo'
committing files:
h
committing manifest
committing changelog
new node id is 03fd98f490cd52c2e3ec48b5f1aa29eb1cfe7b90
moving bookmarks ['b1'] from e6dd2bf0e93e140e9b185d8df7d2fd55b01c270a to 03fd98f490cd52c2e3ec48b5f1aa29eb1cfe7b90
resolving manifests
branchmerge: False, force: False, partial: False
ancestor: e6dd2bf0e93e, local: e6dd2bf0e93e+, remote: 03fd98f490cd
changed branch on 2 changesets
updating the branch cache
invalid branchheads cache (served): tip differs
$ hg glog -r .
@ 12:03fd98f490cd Added h
| foo (b1)
~
$ hg glog
@ 12:03fd98f490cd Added h
| foo (b1)
o 11:6bcbfdc170f7 Added g
| foo ()
o 8:e47e2354372c Added f
| bar ()
o 4:aa98ab95a928 Added e
| default ()
o 3:62615734edd5 Added d
| default ()
o 2:28ad74487de9 Added c
| default ()
o 1:29becc82797a Added b
| default ()
o 0:18d04c59bb5d Added a
default ()
Make sure phase handling is correct
$ echo foo >> bar
$ hg ci -Aqm "added bar" --secret
$ hg glog -r .
@ 13:f11139b5413b added bar
| foo (b1)
~
$ hg branch -r . secret
changed branch on 1 changesets
$ hg phase -r .
14: secret
$ hg branches
secret 14:42e97792ed5d
foo 12:03fd98f490cd (inactive)
bar 8:e47e2354372c (inactive)
default 4:aa98ab95a928 (inactive)
$ hg branch
secret
Changing branch of another head, different from one on which we are
$ hg rebase -s 3 -d 1 -q --keepbranches
$ hg glog
@ 20:4312b52874e6 added bar
| secret (b1)
o 19:d8a0d829626c Added h
| foo ()
o 18:a3992cbc5da1 Added g
| foo ()
o 17:271f592ffeb1 Added f
| bar ()
o 16:21bf4f045390 Added e
| default ()
o 15:a032b5424026 Added d
| default ()
| o 2:28ad74487de9 Added c
|/ default ()
o 1:29becc82797a Added b
| default ()
o 0:18d04c59bb5d Added a
default ()
$ hg branches
secret 20:4312b52874e6
default 16:21bf4f045390
foo 19:d8a0d829626c (inactive)
bar 17:271f592ffeb1 (inactive)
$ hg branch
secret
$ hg branch -r 2 foobar
changed branch on 1 changesets
$ hg glog
o 21:13c2545aa399 Added c
| foobar ()
| @ 20:4312b52874e6 added bar
| | secret (b1)
| o 19:d8a0d829626c Added h
| | foo ()
| o 18:a3992cbc5da1 Added g
| | foo ()
| o 17:271f592ffeb1 Added f
| | bar ()
| o 16:21bf4f045390 Added e
| | default ()
| o 15:a032b5424026 Added d
|/ default ()
o 1:29becc82797a Added b
| default ()
o 0:18d04c59bb5d Added a
default ()
$ hg branches
foobar 21:13c2545aa399
dlaxUnsubmitted
Done

typo: mutliple

dlax: typo: mutliple
secret 20:4312b52874e6
foo 19:d8a0d829626c (inactive)
bar 17:271f592ffeb1 (inactive)
default 16:21bf4f045390 (inactive)
The current branch must be preserved
$ hg branch
secret
Changing branch on multiple heads at once
$ hg branch -r 1: wat
changed branch on 8 changesets
$ hg glog
o 29:96deb8de5734 Added c
| wat ()
| @ 28:90f2960c3410 added bar
| | wat (b1)
| o 27:a285fc5cd0b9 Added h
| | wat ()
| o 26:6906ec2d36a8 Added g
| | wat ()
| o 25:00fbab1bf47f Added f
| | wat ()
| o 24:1a764b704348 Added e
| | wat ()
| o 23:5d2e3635fbc0 Added d
|/ wat ()
o 22:aa56aac9964f Added b
| wat ()
o 0:18d04c59bb5d Added a
default ()
$ hg branches
wat 29:96deb8de5734
default 0:18d04c59bb5d (inactive)
$ hg branch
wat
Changing branch on public changeset
$ hg phase -r 29 -p
$ hg branch -r 29 stable
abort: cannot change branch of public revisions
[255]
Changing to same branch name is no-op
$ hg branch -r 23::28 wat
changed branch on 0 changesets
ryanmceUnsubmitted
Not Done

Hm, I think I'd prefer this to be an error about public changesets rather than a no-op with a 0 return value. Trying to modify the branch of public changesets -- even if the change is a no-op, still seems like an error to me. Thoughts?

ryanmce: Hm, I think I'd prefer this to be an error about public changesets rather than a no-op with a 0…
pulkitAuthorUnsubmitted
Not Done

Oh, no. They are not public changesets. The test for public changeset is just above it. I will plug the phase info in the glog output in next version.

pulkit: Oh, no. They are not public changesets. The test for public changeset is just above it. I will…
$ hg glog
o 29:96deb8de5734 Added c
| wat ()
| @ 28:90f2960c3410 added bar
| | wat (b1)
| o 27:a285fc5cd0b9 Added h
| | wat ()
| o 26:6906ec2d36a8 Added g
| | wat ()
| o 25:00fbab1bf47f Added f
| | wat ()
| o 24:1a764b704348 Added e
| | wat ()
| o 23:5d2e3635fbc0 Added d
|/ wat ()
o 22:aa56aac9964f Added b
| wat ()
o 0:18d04c59bb5d Added a
default ()

tests/test-completion.t

status: all, modified, added, removed, deleted, clean, unknown, ignored, no-status, terse, copies, print0, rev, change, include, exclude, subrepos, template status: all, modified, added, removed, deleted, clean, unknown, ignored, no-status, terse, copies, print0, rev, change, include, exclude, subrepos, template
summary: remote summary: remote
update: clean, check, merge, date, rev, tool update: clean, check, merge, date, rev, tool
addremove: similarity, subrepos, include, exclude, dry-run addremove: similarity, subrepos, include, exclude, dry-run
archive: no-decode, prefix, rev, type, subrepos, include, exclude archive: no-decode, prefix, rev, type, subrepos, include, exclude
backout: merge, commit, no-commit, parent, rev, edit, tool, include, exclude, message, logfile, date, user backout: merge, commit, no-commit, parent, rev, edit, tool, include, exclude, message, logfile, date, user
bisect: reset, good, bad, skip, extend, command, noupdate bisect: reset, good, bad, skip, extend, command, noupdate
bookmarks: force, rev, delete, rename, inactive, template bookmarks: force, rev, delete, rename, inactive, template
branch: force, clean branch: force, clean, rev
branches: active, closed, template branches: active, closed, template
bundle: force, rev, branch, base, all, type, ssh, remotecmd, insecure bundle: force, rev, branch, base, all, type, ssh, remotecmd, insecure
cat: output, rev, decode, include, exclude, template cat: output, rev, decode, include, exclude, template
config: untrusted, edit, local, global, template config: untrusted, edit, local, global, template
copy: after, force, include, exclude, dry-run copy: after, force, include, exclude, dry-run
debugancestor: debugancestor:
debugapplystreamclonebundle: debugapplystreamclonebundle:
debugbuilddag: mergeable-file, overwritten-file, new-file debugbuilddag: mergeable-file, overwritten-file, new-file