Page MenuHomePhabricator

compat: enforce upper case drive letter in mercurial too
AcceptedPublic

Authored by marmoute on Jul 9 2021, 9:00 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Summary

This is affecting code that checks if a pull/push destination is the same as a
configured one. For example the bookmark divergence creation code.

Doing this fixes test-bookmarks.t and test-bookflow.t on Windows.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Jul 9 2021, 9:00 PM
marmoute planned changes to this revision.Jul 9 2021, 9:02 PM

Actually, test-bookmarks is still broken on Windows, so lets investigate further

baymax updated this revision to Diff 29111.Jul 9 2021, 11:41 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

mharbison72 added inline comments.
mercurial/encoding.py
370–371

I'm a little confused by this. Is this making py3.7 and py3.8 runs consistent, or is there something unreliable about py3.8 itself with the upper casing?

marmoute added inline comments.Jul 11 2021, 7:29 AM
mercurial/encoding.py
370–371

This is making Windows consistent with Windows, regardless of Python version.

Alphare accepted this revision.Jul 13 2021, 11:18 AM
This revision is now accepted and ready to land.Jul 13 2021, 11:18 AM

Seems fine, needs rebased.