This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2160

py3: use b'' in inline extension
ClosedPublic

Authored by indygreg on Feb 11 2018, 9:35 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGa42817fede27: py3: use b'' in inline extension
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Feb 11 2018, 9:35 PM
pulkit accepted this revision.Feb 12 2018, 2:34 AM
pulkit added a subscriber: pulkit.

This should be # skip-blame.

Closed by commit rHGa42817fede27: py3: use b'' in inline extension (authored by indygreg). · Explain WhyFeb 12 2018, 9:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-largefiles-small-disk.t (2 lines)

Diff 5461

tests/test-largefiles-small-disk.t

Test how largefiles abort in case the disk runs full Test how largefiles abort in case the disk runs full
$ cat > criple.py <<EOF $ cat > criple.py <<EOF
> from __future__ import absolute_import > from __future__ import absolute_import
> import errno > import errno
> import os > import os
> import shutil > import shutil
> from mercurial import util > from mercurial import util
> # > #
> # this makes the original largefiles code abort: > # this makes the original largefiles code abort:
> _origcopyfileobj = shutil.copyfileobj > _origcopyfileobj = shutil.copyfileobj
> def copyfileobj(fsrc, fdst, length=16*1024): > def copyfileobj(fsrc, fdst, length=16*1024):
> # allow journal files (used by transaction) to be written > # allow journal files (used by transaction) to be written
> if 'journal.' in fdst.name: > if b'journal.' in fdst.name:
> return _origcopyfileobj(fsrc, fdst, length) > return _origcopyfileobj(fsrc, fdst, length)
> fdst.write(fsrc.read(4)) > fdst.write(fsrc.read(4))
> raise IOError(errno.ENOSPC, os.strerror(errno.ENOSPC)) > raise IOError(errno.ENOSPC, os.strerror(errno.ENOSPC))
> shutil.copyfileobj = copyfileobj > shutil.copyfileobj = copyfileobj
> # > #
> # this makes the rewritten code abort: > # this makes the rewritten code abort:
> def filechunkiter(f, size=131072, limit=None): > def filechunkiter(f, size=131072, limit=None):
> yield f.read(4) > yield f.read(4)