This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2161

py3: use b'' for changegroup version literals
ClosedPublic

Authored by indygreg on Feb 11 2018, 9:35 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG83246d6920f2: py3: use b'' for changegroup version literals
Summary

Test extensions aren't currently loaded with our custom module
importer.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Feb 11 2018, 9:35 PM
pulkit accepted this revision.Feb 12 2018, 2:35 AM
pulkit added a subscriber: pulkit.

This should be # skip-blame.

Closed by commit rHG83246d6920f2: py3: use b'' for changegroup version literals (authored by indygreg). · Explain WhyFeb 12 2018, 9:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/flagprocessorext.py (10 lines)

Diff 5462

tests/flagprocessorext.py

def gzipcompress(self, text): def gzipcompress(self, text):
return (zlib.compress(text), False) return (zlib.compress(text), False)
def gzipdecompress(self, text): def gzipdecompress(self, text):
return (zlib.decompress(text), True) return (zlib.decompress(text), True)
def supportedoutgoingversions(orig, repo): def supportedoutgoingversions(orig, repo):
versions = orig(repo) versions = orig(repo)
versions.discard('01') versions.discard(b'01')
versions.discard('02') versions.discard(b'02')
versions.add('03') versions.add(b'03')
return versions return versions
def allsupportedversions(orig, ui): def allsupportedversions(orig, ui):
versions = orig(ui) versions = orig(ui)
versions.add('03') versions.add(b'03')
return versions return versions
def noopaddrevision(orig, self, text, transaction, link, p1, p2, def noopaddrevision(orig, self, text, transaction, link, p1, p2,
cachedelta=None, node=None, cachedelta=None, node=None,
flags=revlog.REVIDX_DEFAULT_FLAGS): flags=revlog.REVIDX_DEFAULT_FLAGS):
if b'[NOOP]' in text: if b'[NOOP]' in text:
flags |= REVIDX_NOOP flags |= REVIDX_NOOP
return orig(self, text, transaction, link, p1, p2, cachedelta=cachedelta, return orig(self, text, transaction, link, p1, p2, cachedelta=cachedelta,
# Teach revlog about our test flags # Teach revlog about our test flags
flags = [REVIDX_NOOP, REVIDX_BASE64, REVIDX_GZIP, REVIDX_FAIL] flags = [REVIDX_NOOP, REVIDX_BASE64, REVIDX_GZIP, REVIDX_FAIL]
revlog.REVIDX_KNOWN_FLAGS |= util.bitsfrom(flags) revlog.REVIDX_KNOWN_FLAGS |= util.bitsfrom(flags)
revlog.REVIDX_FLAGS_ORDER.extend(flags) revlog.REVIDX_FLAGS_ORDER.extend(flags)
# Teach exchange to use changegroup 3 # Teach exchange to use changegroup 3
for k in exchange._bundlespeccgversions.keys(): for k in exchange._bundlespeccgversions.keys():
exchange._bundlespeccgversions[k] = '03' exchange._bundlespeccgversions[k] = b'03'
# Add wrappers for addrevision, responsible to set flags depending on the # Add wrappers for addrevision, responsible to set flags depending on the
# revision data contents. # revision data contents.
wrapfunction(filelog.filelog, 'addrevision', noopaddrevision) wrapfunction(filelog.filelog, 'addrevision', noopaddrevision)
wrapfunction(filelog.filelog, 'addrevision', b64addrevision) wrapfunction(filelog.filelog, 'addrevision', b64addrevision)
wrapfunction(filelog.filelog, 'addrevision', gzipaddrevision) wrapfunction(filelog.filelog, 'addrevision', gzipaddrevision)
wrapfunction(filelog.filelog, 'addrevision', failaddrevision) wrapfunction(filelog.filelog, 'addrevision', failaddrevision)