( )⚙ D2899 wireproto: define attr-based classes for representing frames

This is an archive of the discontinued Mercurial Phabricator instance.

wireproto: define attr-based classes for representing frames
ClosedPublic

Authored by indygreg on Mar 19 2018, 5:41 PM.

Details

Summary

When frames only had 3 attributes, it was reasonable to
represent them as a tuple. With them growing more attributes,
it will be easier to pass them around as a more formal type.
So let's define attr-based classes to represent frame headers and
full frames.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Mar 19 2018, 5:41 PM
durin42 accepted this revision.Mar 21 2018, 9:33 PM
This revision is now accepted and ready to land.Mar 21 2018, 9:33 PM
This revision was automatically updated to reflect the committed changes.