( )⚙ D11117 dirstate-item: use an explicit __init__ function instead of the attrs one

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11117

dirstate-item: use an explicit __init__ function instead of the attrs one
ClosedPublic

Authored by marmoute on Jul 19 2021, 6:38 AM.

Details

Reviewers
Alphare
pulkit
Group Reviewers
hg-reviewers
Commits
rHG119b9c8db94d: dirstate-item: use an explicit __init__ function instead of the attrs one
Summary

For now, this is not doing anything special, however we plan to make it different in the future. So we start simple.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jul 19 2021, 6:38 AM
Alphare accepted this revision.Jul 19 2021, 12:27 PM
This revision is now accepted and ready to land.Jul 19 2021, 12:27 PM
pulkit accepted this revision.Jul 19 2021, 8:03 PM
baymax updated this revision to Diff 29536.Jul 20 2021, 3:20 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Revision Contents
Changeset List

PathPackages
Mmercurial/pure/parsers.py (8 lines)

Diff 29594

mercurial/pure/parsers.py

# a special value used internally for `size` if the file is modified/merged/added # a special value used internally for `size` if the file is modified/merged/added
NONNORMAL = -1 NONNORMAL = -1
# a special value used internally for `time` if the time is ambigeous # a special value used internally for `time` if the time is ambigeous
AMBIGUOUS_TIME = -1 AMBIGUOUS_TIME = -1
@attr.s(slots=True) @attr.s(slots=True, init=False)
class DirstateItem(object): class DirstateItem(object):
"""represent a dirstate entry """represent a dirstate entry
It contains: It contains:
- state (one of 'n', 'a', 'r', 'm') - state (one of 'n', 'a', 'r', 'm')
- mode, - mode,
- size, - size,
- mtime, - mtime,
""" """
_state = attr.ib() _state = attr.ib()
_mode = attr.ib() _mode = attr.ib()
_size = attr.ib() _size = attr.ib()
_mtime = attr.ib() _mtime = attr.ib()
def __init__(self, state, mode, size, mtime):
self._state = state
self._mode = mode
self._size = size
self._mtime = mtime
def __getitem__(self, idx): def __getitem__(self, idx):
if idx == 0 or idx == -4: if idx == 0 or idx == -4:
msg = b"do not use item[x], use item.state" msg = b"do not use item[x], use item.state"
util.nouideprecwarn(msg, b'6.0', stacklevel=2) util.nouideprecwarn(msg, b'6.0', stacklevel=2)
return self._state return self._state
elif idx == 1 or idx == -3: elif idx == 1 or idx == -3:
msg = b"do not use item[x], use item.mode" msg = b"do not use item[x], use item.mode"
util.nouideprecwarn(msg, b'6.0', stacklevel=2) util.nouideprecwarn(msg, b'6.0', stacklevel=2)