This is an archive of the discontinued Mercurial Phabricator instance.

py3: port string formatting
ClosedPublic

Authored by indygreg on Feb 11 2018, 5:57 PM.

Details

Summary

skipped is a set of integer revs here. So cast integers to
strings using %d.

None doesn't cast to an empty string on Python 3. So use '' explicitly.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Feb 11 2018, 5:57 PM
yuja requested changes to this revision.Feb 11 2018, 8:43 PM
yuja added a subscriber: yuja.

r looks like an integer, and bytes(int) is '\0' * int.

This revision now requires changes to proceed.Feb 11 2018, 8:43 PM
indygreg edited the summary of this revision. (Show Details)Feb 11 2018, 9:35 PM
indygreg updated this revision to Diff 5452.
pulkit accepted this revision.Feb 12 2018, 2:14 AM
yuja accepted this revision.Feb 13 2018, 7:11 AM
This revision is now accepted and ready to land.Feb 13 2018, 7:11 AM
This revision was automatically updated to reflect the committed changes.