( )⚙ D2170 py3: make dummyssh compatible with Python 3

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2170

py3: make dummyssh compatible with Python 3
ClosedPublic

Authored by indygreg on Feb 11 2018, 10:45 PM.

Details

Reviewers
pulkit
durin42
Group Reviewers
hg-reviewers
Commits
rHG3a763d7f40e1: py3: make dummyssh compatible with Python 3
rHG9996ec844c1e: py3: make dummyssh compatible with Python 3
Summary

Required encoding a str to bytes and writing bytes to a file
descriptor.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Feb 11 2018, 10:45 PM
pulkit accepted this revision.Feb 12 2018, 2:45 AM
durin42 accepted this revision.Feb 12 2018, 9:32 PM
This revision is now accepted and ready to land.Feb 12 2018, 9:32 PM
Closed by commit rHG9996ec844c1e: py3: make dummyssh compatible with Python 3 (authored by indygreg). · Explain WhyFeb 12 2018, 9:48 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/dummyssh (4 lines)

Diff 5471

tests/dummyssh

if sys.argv[1] != "user@dummy": if sys.argv[1] != "user@dummy":
sys.exit(-1) sys.exit(-1)
os.environ["SSH_CLIENT"] = "%s 1 2" % os.environ.get('LOCALIP', '127.0.0.1') os.environ["SSH_CLIENT"] = "%s 1 2" % os.environ.get('LOCALIP', '127.0.0.1')
log = open("dummylog", "ab") log = open("dummylog", "ab")
log.write(b"Got arguments") log.write(b"Got arguments")
for i, arg in enumerate(sys.argv[1:]): for i, arg in enumerate(sys.argv[1:]):
log.write(b" %d:%s" % (i + 1, arg)) log.write(b" %d:%s" % (i + 1, arg.encode('latin1')))
log.write("\n") log.write(b"\n")
log.close() log.close()
hgcmd = sys.argv[2] hgcmd = sys.argv[2]
if os.name == 'nt': if os.name == 'nt':
# hack to make simple unix single quote quoting work on windows # hack to make simple unix single quote quoting work on windows
hgcmd = hgcmd.replace("'", '"') hgcmd = hgcmd.replace("'", '"')
r = os.system(hgcmd) r = os.system(hgcmd)
sys.exit(bool(r)) sys.exit(bool(r))